Issue 25002005: Telemetry / Android: do not crash on GetCpuStats() if the process is gone.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25002005: Telemetry / Android: do not crash on GetCpuStats() if the process is gone. (Closed)

Created:
7 years, 2 months ago by bulach

Modified:
7 years, 2 months ago

Reviewers:
tonyg, nduca

CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Telemetry / Android: do not crash on GetCpuStats() if the process is gone. Some bots are failing with: ...[0].split() IndexError: list index out of range This can specially happen on page cyclers, since multiple renders can be started and killed by the framework. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226642

Patch Set 1 #

Patch Set 2 : Unittests! #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -2 lines)			Patch
M	tools/telemetry/telemetry/core/platform/android_platform_backend.py	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download
A	tools/telemetry/telemetry/core/platform/android_platform_backend_unittest.py	View	1	1 chunk	+49 lines, -0 lines	0 comments	Download
M	tools/telemetry/telemetry/unittest/system_stub.py	View	1	2 chunks	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bulach

I'm not quite sure what would be the impact on higher up layers, but I ...

7 years, 2 months ago (2013-09-27 16:27:46 UTC) #1

bulach

good idea! added unittests and some stubs up in telemetry/unittests/system_stub.py..

7 years, 2 months ago (2013-10-02 09:36:05 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/25002005/8001

7 years, 2 months ago (2013-10-02 21:08:08 UTC) #4

Message was sent while issue was closed.

Change committed as 226642

Expand Messages | Collapse Messages