Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3565)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java

Issue 2500183002: Do not parse JSON in the browser. (Closed)
Patch Set: Use a Dictionary type in IDL Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
index 8abccce075c89cf5ef3f0d5de704803433048d3d..3766063cf195414e254659fb57e0e7f214c230bf 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
@@ -12,8 +12,6 @@ import android.widget.CheckBox;
import android.widget.EditText;
import android.widget.Spinner;
-import org.json.JSONObject;
-
import org.chromium.base.ThreadUtils;
import org.chromium.base.test.util.CallbackHelper;
import org.chromium.base.test.util.RetryOnFailure;
@@ -36,6 +34,7 @@ import org.chromium.content.browser.test.util.CriteriaHelper;
import org.chromium.content.browser.test.util.DOMUtils;
import org.chromium.content_public.browser.WebContents;
import org.chromium.payments.mojom.PaymentItem;
+import org.chromium.payments.mojom.PaymentMethodData;
import java.util.ArrayList;
import java.util.HashSet;
@@ -722,8 +721,8 @@ abstract class PaymentRequestTestBase extends ChromeActivityTestCaseBase<ChromeT
}
@Override
- public void getInstruments(
- Map<String, JSONObject> methodData, final InstrumentsCallback instrumentsCallback) {
+ public void getInstruments(Map<String, PaymentMethodData> methodData,
+ InstrumentsCallback instrumentsCallback) {
mCallback = instrumentsCallback;
respond();
}
@@ -776,7 +775,7 @@ abstract class PaymentRequestTestBase extends ChromeActivityTestCaseBase<ChromeT
@Override
public void getInstrumentDetails(String merchantName, String origin, PaymentItem total,
- List<PaymentItem> cart, JSONObject details,
+ List<PaymentItem> cart, PaymentMethodData details,
InstrumentDetailsCallback detailsCallback) {
detailsCallback.onInstrumentDetailsReady(
mMethodName, "{\"transaction\": 1337}");

Powered by Google App Engine
This is Rietveld 408576698