Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2500163002: Create ppd_cache directory if it doesn't exist. Also, rename it to CamelCase to match the observed… (Closed)

Created:
4 years, 1 month ago by Carlson
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create ppd_cache directory if it doesn't exist. Also, rename it to CamelCase to match the observed conventions of other things in /home/chronos. The name change is safe because no one uses this directory yet. No one uses it yet because all the functionality that *would* use it is failing because...the directory is never created. BUG=662755 Committed: https://crrev.com/cf123fc79469b4b77050b828bf3c94bf88af7183 Cr-Commit-Position: refs/heads/master@{#432080}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/common/chrome_paths.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Carlson
sky@ can you take a quick look?
4 years, 1 month ago (2016-11-14 21:58:31 UTC) #2
sky
LGTM
4 years, 1 month ago (2016-11-14 23:14:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2500163002/1
4 years, 1 month ago (2016-11-14 23:31:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-15 03:47:05 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 03:51:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf123fc79469b4b77050b828bf3c94bf88af7183
Cr-Commit-Position: refs/heads/master@{#432080}

Powered by Google App Engine
This is Rietveld 408576698