Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Side by Side Diff: chrome/android/java/AndroidManifest.xml

Issue 2500153003: Fix broken VR transitions due to ChromeTabbedActivity not being exported. (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <!-- 6 <!--
7 Note: This is a jinja2 template, processed at build time into the final manifest . 7 Note: This is a jinja2 template, processed at build time into the final manifest .
8 8
9 Blocks denoted with { % block some_name % }foo{ % endblock % } can be overridden 9 Blocks denoted with { % block some_name % }foo{ % endblock % } can be overridden
10 by a child template that "extends" this file. 10 by a child template that "extends" this file.
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 <uses-permission android:name="android.permission.READ_SYNC_SETTINGS"/> 46 <uses-permission android:name="android.permission.READ_SYNC_SETTINGS"/>
47 <uses-permission android:name="android.permission.READ_SYNC_STATS"/> 47 <uses-permission android:name="android.permission.READ_SYNC_STATS"/>
48 <uses-permission android:name="android.permission.RECEIVE_BOOT_COMPLETED"/> 48 <uses-permission android:name="android.permission.RECEIVE_BOOT_COMPLETED"/>
49 <uses-permission android:name="android.permission.RECORD_AUDIO"/> 49 <uses-permission android:name="android.permission.RECORD_AUDIO"/>
50 <uses-permission android:name="android.permission.USE_CREDENTIALS"/> 50 <uses-permission android:name="android.permission.USE_CREDENTIALS"/>
51 <uses-permission android:name="android.permission.VIBRATE"/> 51 <uses-permission android:name="android.permission.VIBRATE"/>
52 <uses-permission android:name="android.permission.WAKE_LOCK"/> 52 <uses-permission android:name="android.permission.WAKE_LOCK"/>
53 <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/> 53 <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>
54 <uses-permission android:name="android.permission.WRITE_SYNC_SETTINGS"/> 54 <uses-permission android:name="android.permission.WRITE_SYNC_SETTINGS"/>
55 {% set enable_vr_shell = enable_vr_shell|default(0) %} 55 {% set enable_vr_shell = enable_vr_shell|default(0) %}
56 {% if enable_vr_shell == "true" %} 56 {% set enable_webvr = enable_webvr|default(0) %}
57 {% if enable_vr_shell == "true" or enable_webvr == "true" %}
57 <!-- Required to read the paired viewer's distortion parameters. --> 58 <!-- Required to read the paired viewer's distortion parameters. -->
58 <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/> 59 <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/>
59 <!-- Indicates use of Android's VR-mode, available only on Android N+. --> 60 <!-- Indicates use of Android's VR-mode, available only on Android N+. -->
60 <uses-feature android:name="android.software.vr.mode" android:required="fals e"/> 61 <uses-feature android:name="android.software.vr.mode" android:required="fals e"/>
61 <!-- Indicates use of VR features that are available only on Daydream-ready devices. --> 62 <!-- Indicates use of VR features that are available only on Daydream-ready devices. -->
62 <uses-feature android:name="android.hardware.vr.high_performance" android:re quired="false"/> 63 <uses-feature android:name="android.hardware.vr.high_performance" android:re quired="false"/>
63 {% endif %} 64 {% endif %}
64 65
65 <permission android:name="{{ manifest_package }}.permission.CHILD_SERVICE" a ndroid:protectionLevel="signature" /> 66 <permission android:name="{{ manifest_package }}.permission.CHILD_SERVICE" a ndroid:protectionLevel="signature" />
66 <permission android:name="{{ manifest_package }}.permission.READ_WRITE_BOOKM ARK_FOLDERS" android:protectionLevel="signatureOrSystem" /> 67 <permission android:name="{{ manifest_package }}.permission.READ_WRITE_BOOKM ARK_FOLDERS" android:protectionLevel="signatureOrSystem" />
(...skipping 280 matching lines...) Expand 10 before | Expand all | Expand 10 after
347 android:windowSoftInputMode="adjustResize" 348 android:windowSoftInputMode="adjustResize"
348 android:persistableMode="persistNever" 349 android:persistableMode="persistNever"
349 android:taskAffinity="" 350 android:taskAffinity=""
350 android:configChanges="orientation|keyboardHidden|keyboard|screenSiz e|mcc|mnc|screenLayout|smallestScreenSize" 351 android:configChanges="orientation|keyboardHidden|keyboard|screenSiz e|mcc|mnc|screenLayout|smallestScreenSize"
351 android:hardwareAccelerated="false"> 352 android:hardwareAccelerated="false">
352 </activity> 353 </activity>
353 {% endfor %} 354 {% endfor %}
354 355
355 <!-- ChromeTabbedActivity related --> 356 <!-- ChromeTabbedActivity related -->
356 <activity android:name="org.chromium.chrome.browser.ChromeTabbedActivity " 357 <activity android:name="org.chromium.chrome.browser.ChromeTabbedActivity "
357 android:theme="@style/TabbedModeTheme" 358 android:theme="@style/TabbedModeTheme"
358 android:exported="false" 359 android:exported="false"
359 android:windowSoftInputMode="adjustResize" 360 android:windowSoftInputMode="adjustResize"
360 android:launchMode="singleTask" 361 android:launchMode="singleTask"
361 android:configChanges="orientation|keyboardHidden|keyboard|screenSi ze|mcc|mnc|screenLayout|smallestScreenSize" 362 android:configChanges="orientation|keyboardHidden|keyboard|screenSiz e|mcc|mnc|screenLayout|smallestScreenSize"
362 android:hardwareAccelerated="false"> 363 android:hardwareAccelerated="false">
363 {% set enable_webvr = enable_webvr|default(0) %} 364 <!--
364 {% if enable_vr_shell == "true" or enable_webvr == "true" %} 365 See the VRChromeTabbedActivity alias below for an explanation of t his dummy intent
366 filter. We need to add these filters here as well, or non-presenti ng webVR pages will
367 trigger a daydream incompatible app message.
368 -->
365 <intent-filter> 369 <intent-filter>
366 <!-- Add a dummy action to match intent without any action. -->
367 <action android:name="org.chromium.chrome.browser.dummy.action" /> 370 <action android:name="org.chromium.chrome.browser.dummy.action" />
368 <!--
369 Daydream api categorizes an activity to three categories: Card board only, hybrid
370 or Daydream. It does so by testing if intents can be resolved by the activity
371 that requests it.
372 In Chrome, CTA is the activity that uses Daydream api and we w ant to be in hybrid
373 category. So add an intent filter that could pass Daydream tes ts here.
374 -->
375 <category android:name="com.google.intent.category.DAYDREAM" /> 371 <category android:name="com.google.intent.category.DAYDREAM" />
376 <category android:name="com.google.intent.category.CARDBOARD" /> 372 <category android:name="com.google.intent.category.CARDBOARD" />
377 </intent-filter> 373 </intent-filter>
378 {% endif %}
379 </activity> 374 </activity>
375
376 {% if enable_vr_shell == "true" or enable_webvr == "true" %}
377 <!--
378 TODO(mthiesse): Temporarily skip ChromeLauncherActivity when returni ng from Daydream
379 DON flow to avoid polluting metrics.
380 -->
381 <activity-alias android:name="org.chromium.chrome.browser.VRChromeTabbed Activity"
382 android:targetActivity="org.chromium.chrome.browser.ChromeTabbedActi vity"
383 android:enableVrMode="@string/gvr_vr_mode_component">
384 <!--
385 Daydream api categorizes an activity to three categories: Cardboar d only, hybrid
386 or Daydream. It does so by testing if intents can be resolved by t he activity
387 that requests it.
388 In Chrome, CTA is the activity that uses Daydream api and we want to be in hybrid
389 category. So add an intent filter that could pass Daydream tests h ere.
390 -->
391 <intent-filter>
392 <action android:name="org.chromium.chrome.browser.dummy.action" />
393 <category android:name="com.google.intent.category.DAYDREAM" />
394 <category android:name="com.google.intent.category.CARDBOARD" />
395 </intent-filter>
396 </activity-alias>
397 {% endif %}
398
380 <activity android:name="org.chromium.chrome.browser.ChromeTabbedActivity 2" 399 <activity android:name="org.chromium.chrome.browser.ChromeTabbedActivity 2"
381 android:theme="@style/TabbedModeTheme" 400 android:theme="@style/TabbedModeTheme"
382 android:exported="false" 401 android:exported="false"
383 android:windowSoftInputMode="adjustResize" 402 android:windowSoftInputMode="adjustResize"
384 android:taskAffinity="{{ manifest_package }}.ChromeTabbedActivity2" 403 android:taskAffinity="{{ manifest_package }}.ChromeTabbedActivity2"
385 android:launchMode="singleTask" 404 android:launchMode="singleTask"
386 android:configChanges="orientation|keyboardHidden|keyboard|screenSi ze|mcc|mnc|screenLayout|smallestScreenSize" 405 android:configChanges="orientation|keyboardHidden|keyboard|screenSi ze|mcc|mnc|screenLayout|smallestScreenSize"
387 android:hardwareAccelerated="false"> 406 android:hardwareAccelerated="false">
388 </activity> 407 </activity>
389 <activity android:name="org.chromium.chrome.browser.multiwindow.MultiIns tanceChromeTabbedActivity" 408 <activity android:name="org.chromium.chrome.browser.multiwindow.MultiIns tanceChromeTabbedActivity"
(...skipping 546 matching lines...) Expand 10 before | Expand all | Expand 10 after
936 choose the first MediaRouteController that can play it, so the orde r of the list can be important. 955 choose the first MediaRouteController that can play it, so the orde r of the list can be important.
937 The most specific MediaRouteControllers should be listed first, fol lowed by more generic ones. 956 The most specific MediaRouteControllers should be listed first, fol lowed by more generic ones.
938 The downstream manifest replaces this block, and hence replaces the list of media route 957 The downstream manifest replaces this block, and hence replaces the list of media route
939 controllers with its own list. --> 958 controllers with its own list. -->
940 <meta-data android:name="org.chromium.content.browser.REMOTE_MEDIA_PLAYE RS" 959 <meta-data android:name="org.chromium.content.browser.REMOTE_MEDIA_PLAYE RS"
941 android:value="org.chromium.chrome.browser.media.remote.DefaultMedia RouteController"/> 960 android:value="org.chromium.chrome.browser.media.remote.DefaultMedia RouteController"/>
942 961
943 {% endblock %} 962 {% endblock %}
944 </application> 963 </application>
945 </manifest> 964 </manifest>
OLDNEW
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698