Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: src/compiler/escape-analysis-reducer.h

Issue 2500143003: [turbofan] Make escape analysis fail silently for cyclic object states (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/escape-analysis-reducer.h
diff --git a/src/compiler/escape-analysis-reducer.h b/src/compiler/escape-analysis-reducer.h
index e5e46b5d60f5b0236a37ca29b13faeced5840957..537f68d26a60d008e8a07a3a888c466fac157bbd 100644
--- a/src/compiler/escape-analysis-reducer.h
+++ b/src/compiler/escape-analysis-reducer.h
@@ -30,6 +30,8 @@ class V8_EXPORT_PRIVATE EscapeAnalysisReducer final
// after this reducer has been applied. Has no effect in release mode.
void VerifyReplacement() const;
+ bool compilation_failed() { return compilation_failed_; }
Benedikt Meurer 2016/11/15 12:42:55 Nit: const
+
private:
Reduction ReduceLoad(Node* node);
Reduction ReduceStore(Node* node);
@@ -55,6 +57,7 @@ class V8_EXPORT_PRIVATE EscapeAnalysisReducer final
// and nodes that do not need a visit from ReduceDeoptState etc.
BitVector fully_reduced_;
bool exists_virtual_allocate_;
+ bool compilation_failed_ = false;
DISALLOW_COPY_AND_ASSIGN(EscapeAnalysisReducer);
};

Powered by Google App Engine
This is Rietveld 408576698