[turbofan] Make escape analysis fail silently for cyclic object states

[turbofan] Make escape analysis fail silently for cyclic object states

R=bmeurer@chromium.org
BUG=v8:5634
Committed: https://crrev.com/f71260b298654942f72f769d7fe281e341e2d2ef
Cr-Commit-Position: refs/heads/master@{#40995}

[Tobias Tebbi, 2016-11-15 12:36:22]

Description was changed from

==========
[turbofan] make escape analysis fail silently for clyclic object states

R=bmeurer@chromium.org

BUG=v8:5634
==========

to

==========
[turbofan] make escape analysis fail silently for cyclic object states

R=bmeurer@chromium.org

BUG=v8:5634
==========

[Benedikt Meurer, 2016-11-15 12:42:55]

LGTM with nits.

https://codereview.chromium.org/2500143003/diff/1/src/bailout-reason.h
File src/bailout-reason.h (right):

https://codereview.chromium.org/2500143003/diff/1/src/bailout-reason.h#newcode64
src/bailout-reason.h:64: V(kEscapeAnalysisFailed, "Escape analysis failed")     
                     \
Nit: Please rename to CyclicObjectStateDetectedInEscapeAnalysis.

https://codereview.chromium.org/2500143003/diff/1/src/compiler/escape-analysi...
File src/compiler/escape-analysis-reducer.h (right):

https://codereview.chromium.org/2500143003/diff/1/src/compiler/escape-analysi...
src/compiler/escape-analysis-reducer.h:33: bool compilation_failed() { return
compilation_failed_; }
Nit: const

[Benedikt Meurer, 2016-11-15 12:43:04]

Description was changed from

==========
[turbofan] make escape analysis fail silently for cyclic object states

R=bmeurer@chromium.org

BUG=v8:5634
==========

to

==========
[turbofan] Make escape analysis fail silently for cyclic object states

R=bmeurer@chromium.org
BUG=v8:5634
==========

[Tobias Tebbi, 2016-11-15 13:00:03]

The CQ bit was checked by tebbi@chromium.org

[Tobias Tebbi, 2016-11-15 13:00:04]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2500143003/#ps20001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-11-15 13:00:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 13:18:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 13:18:10]

Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[Tobias Tebbi, 2016-11-15 13:37:45]

The CQ bit was checked by tebbi@chromium.org

[Tobias Tebbi, 2016-11-15 13:37:45]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2500143003/#ps40001
(title: "regolden")

[commit-bot: I haz the power, 2016-11-15 13:37:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 14:05:00]

Description was changed from

==========
[turbofan] Make escape analysis fail silently for cyclic object states

R=bmeurer@chromium.org
BUG=v8:5634
==========

to

==========
[turbofan] Make escape analysis fail silently for cyclic object states

R=bmeurer@chromium.org
BUG=v8:5634
==========

[commit-bot: I haz the power, 2016-11-15 14:05:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-17 22:34:13]

Description was changed from

==========
[turbofan] Make escape analysis fail silently for cyclic object states

R=bmeurer@chromium.org
BUG=v8:5634
==========

to

==========
[turbofan] Make escape analysis fail silently for cyclic object states

R=bmeurer@chromium.org
BUG=v8:5634

Committed: https://crrev.com/f71260b298654942f72f769d7fe281e341e2d2ef
Cr-Commit-Position: refs/heads/master@{#40995}
==========

[commit-bot: I haz the power, 2016-11-17 22:34:14]

Patchset 3 (id:??) landed as
https://crrev.com/f71260b298654942f72f769d7fe281e341e2d2ef
Cr-Commit-Position: refs/heads/master@{#40995}