Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 2500143002: Disable the hint produced when invoking a super member that is abstract when super-in-mixins is sup… (Closed)

Created:
4 years, 1 month ago by Brian Wilkerson
Modified:
4 years, 1 month ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Disable the hint produced when invoking a super member that is abstract when super-in-mixins is supported R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/40cbb6ec1557cdf4dcea293403eeb98fbe6b1057

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/non_hint_code_test.dart View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
I decided it would be faster to fix it than to open an issue.
4 years, 1 month ago (2016-11-14 21:45:31 UTC) #2
Paul Berry
lgtm
4 years, 1 month ago (2016-11-14 21:51:14 UTC) #3
Brian Wilkerson
4 years, 1 month ago (2016-11-14 21:51:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
40cbb6ec1557cdf4dcea293403eeb98fbe6b1057 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698