Chromium Code Reviews Chromium Code Reviews
Issue 2500133002:
Replace streams tests with automatically-imported ones (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| (Empty) | |
| 1 CONSOLE ERROR: line 725: Uncaught (in promise) TypeError: This readable stream r eader has been released and cannot be used to monitor the stream's state | |
| 2 CONSOLE ERROR: line 725: Uncaught (in promise) TypeError: This readable stream r eader has been released and cannot be used to monitor the stream's state | |
| 3 This is a testharness.js-based test. | |
| 4 PASS ReadableStream can be constructed with no errors | |
| 5 PASS ReadableStream can't be constructed with garbage | |
| 6 PASS ReadableStream can't be constructed with an invalid type | |
| 7 FAIL ReadableStream instances should have the correct list of properties assert_ array_equals: should have all the correct methods lengths differ, expected 7 got 5 | |
| 8 PASS ReadableStream constructor should throw for non-function start arguments | |
| 9 PASS ReadableStream constructor can get initial garbage as cancel argument | |
| 10 PASS ReadableStream constructor can get initial garbage as pull argument | |
| 11 FAIL ReadableStream start should be called with the proper parameters assert_equ als: constructor should have 4 parameter expected 4 but got 5 | |
|
Adam Rice
2016/11/15 06:55:42
What's a good way to fix this?
| |
| 12 PASS ReadableStream start controller parameter should be extensible | |
| 13 PASS ReadableStream should be able to call start method within prototype chain o f its source | |
| 14 PASS ReadableStream start should be able to return a promise | |
| 15 PASS ReadableStream start should be able to return a promise and reject it | |
| 16 PASS ReadableStream should be able to enqueue different objects. | |
| 17 PASS ReadableStream: if pull rejects, it should error the stream | |
| 18 PASS ReadableStream: should only call pull once upon starting the stream | |
| 19 PASS ReadableStream: should call pull when trying to read from a started, empty stream | |
| 20 PASS ReadableStream: should only call pull once on a non-empty stream read from before start fulfills | |
| 21 PASS ReadableStream: should only call pull once on a non-empty stream read from after start fulfills | |
| 22 PASS ReadableStream: should call pull in reaction to read()ing the last chunk, i f not draining | |
| 23 PASS ReadableStream: should not call pull() in reaction to read()ing the last ch unk, if draining | |
| 24 PASS ReadableStream: should not call pull until the previous pull call's promise fulfills | |
| 25 PASS ReadableStream: should pull after start, and after every read | |
| 26 PASS ReadableStream: should not call pull after start if the stream is now close d | |
| 27 PASS ReadableStream: should call pull after enqueueing from inside pull (with no read requests), if strategy allows | |
| 28 PASS ReadableStream pull should be able to close a stream. | |
| 29 PASS ReadableStream pull should be able to error a stream. | |
| 30 PASS ReadableStream pull should be able to error a stream and throw. | |
| 31 PASS ReadableStream: enqueue should throw when the stream is readable but draini ng | |
| 32 PASS ReadableStream: enqueue should throw when the stream is closed | |
| 33 PASS ReadableStream: should call underlying source methods as methods | |
| 34 PASS ReadableStream strategies: the default strategy should give desiredSize of 1 to start, decreasing by 1 per enqueue | |
| 35 PASS ReadableStream strategies: the default strategy should continue giving desi redSize of 1 if the chunks are read immediately | |
| 36 PASS ReadableStream integration test: adapting a random push source | |
| 37 PASS ReadableStream integration test: adapting a sync pull source | |
| 38 PASS ReadableStream integration test: adapting an async pull source | |
| 39 PASS Untitled | |
| 40 PASS ReadableStream can be constructed with no errors | |
| 41 PASS ReadableStream can't be constructed with garbage | |
| 42 PASS ReadableStream can't be constructed with an invalid type | |
| 43 FAIL ReadableStream instances should have the correct list of properties assert_ array_equals: should have all the correct methods lengths differ, expected 7 got 5 | |
| 44 PASS ReadableStream constructor should throw for non-function start arguments | |
| 45 PASS ReadableStream constructor can get initial garbage as cancel argument | |
| 46 PASS ReadableStream constructor can get initial garbage as pull argument | |
| 47 FAIL ReadableStream start should be called with the proper parameters assert_equ als: constructor should have 4 parameter expected 4 but got 5 | |
| 48 PASS ReadableStream start controller parameter should be extensible | |
| 49 PASS ReadableStream should be able to call start method within prototype chain o f its source | |
| 50 PASS ReadableStream start should be able to return a promise | |
| 51 PASS ReadableStream start should be able to return a promise and reject it | |
| 52 PASS ReadableStream should be able to enqueue different objects. | |
| 53 PASS ReadableStream: if pull rejects, it should error the stream | |
| 54 PASS ReadableStream: should only call pull once upon starting the stream | |
| 55 PASS ReadableStream: should call pull when trying to read from a started, empty stream | |
| 56 PASS ReadableStream: should only call pull once on a non-empty stream read from before start fulfills | |
| 57 PASS ReadableStream: should only call pull once on a non-empty stream read from after start fulfills | |
| 58 PASS ReadableStream: should call pull in reaction to read()ing the last chunk, i f not draining | |
| 59 PASS ReadableStream: should not call pull() in reaction to read()ing the last ch unk, if draining | |
| 60 PASS ReadableStream: should not call pull until the previous pull call's promise fulfills | |
| 61 PASS ReadableStream: should pull after start, and after every read | |
| 62 PASS ReadableStream: should not call pull after start if the stream is now close d | |
| 63 PASS ReadableStream: should call pull after enqueueing from inside pull (with no read requests), if strategy allows | |
| 64 PASS ReadableStream pull should be able to close a stream. | |
| 65 PASS ReadableStream pull should be able to error a stream. | |
| 66 PASS ReadableStream pull should be able to error a stream and throw. | |
| 67 PASS ReadableStream: enqueue should throw when the stream is readable but draini ng | |
| 68 PASS ReadableStream: enqueue should throw when the stream is closed | |
| 69 PASS ReadableStream: should call underlying source methods as methods | |
| 70 PASS ReadableStream strategies: the default strategy should give desiredSize of 1 to start, decreasing by 1 per enqueue | |
| 71 PASS ReadableStream strategies: the default strategy should continue giving desi redSize of 1 if the chunks are read immediately | |
| 72 PASS ReadableStream integration test: adapting a random push source | |
| 73 PASS ReadableStream integration test: adapting a sync pull source | |
| 74 PASS ReadableStream integration test: adapting an async pull source | |
| 75 PASS ReadableStream can be constructed with no errors | |
| 76 PASS ReadableStream can't be constructed with garbage | |
| 77 PASS ReadableStream can't be constructed with an invalid type | |
| 78 FAIL ReadableStream instances should have the correct list of properties assert_ array_equals: should have all the correct methods lengths differ, expected 7 got 5 | |
| 79 PASS ReadableStream constructor should throw for non-function start arguments | |
| 80 PASS ReadableStream constructor can get initial garbage as cancel argument | |
| 81 PASS ReadableStream constructor can get initial garbage as pull argument | |
| 82 FAIL ReadableStream start should be called with the proper parameters assert_equ als: constructor should have 4 parameter expected 4 but got 5 | |
| 83 PASS ReadableStream start controller parameter should be extensible | |
| 84 PASS ReadableStream should be able to call start method within prototype chain o f its source | |
| 85 PASS ReadableStream start should be able to return a promise | |
| 86 PASS ReadableStream start should be able to return a promise and reject it | |
| 87 PASS ReadableStream should be able to enqueue different objects. | |
| 88 PASS ReadableStream: if pull rejects, it should error the stream | |
| 89 PASS ReadableStream: should only call pull once upon starting the stream | |
| 90 PASS ReadableStream: should call pull when trying to read from a started, empty stream | |
| 91 PASS ReadableStream: should only call pull once on a non-empty stream read from before start fulfills | |
| 92 PASS ReadableStream: should only call pull once on a non-empty stream read from after start fulfills | |
| 93 PASS ReadableStream: should call pull in reaction to read()ing the last chunk, i f not draining | |
| 94 PASS ReadableStream: should not call pull() in reaction to read()ing the last ch unk, if draining | |
| 95 PASS ReadableStream: should not call pull until the previous pull call's promise fulfills | |
| 96 PASS ReadableStream: should pull after start, and after every read | |
| 97 PASS ReadableStream: should not call pull after start if the stream is now close d | |
| 98 PASS ReadableStream: should call pull after enqueueing from inside pull (with no read requests), if strategy allows | |
| 99 PASS ReadableStream pull should be able to close a stream. | |
| 100 PASS ReadableStream pull should be able to error a stream. | |
| 101 PASS ReadableStream pull should be able to error a stream and throw. | |
| 102 PASS ReadableStream: enqueue should throw when the stream is readable but draini ng | |
| 103 PASS ReadableStream: enqueue should throw when the stream is closed | |
| 104 PASS ReadableStream: should call underlying source methods as methods | |
| 105 PASS ReadableStream strategies: the default strategy should give desiredSize of 1 to start, decreasing by 1 per enqueue | |
| 106 PASS ReadableStream strategies: the default strategy should continue giving desi redSize of 1 if the chunks are read immediately | |
| 107 PASS ReadableStream integration test: adapting a random push source | |
| 108 PASS ReadableStream integration test: adapting a sync pull source | |
| 109 PASS ReadableStream integration test: adapting an async pull source | |
| 110 PASS ReadableStream can be constructed with no errors | |
| 111 PASS ReadableStream can't be constructed with garbage | |
| 112 PASS ReadableStream can't be constructed with an invalid type | |
| 113 FAIL ReadableStream instances should have the correct list of properties assert_ array_equals: should have all the correct methods lengths differ, expected 7 got 5 | |
| 114 PASS ReadableStream constructor should throw for non-function start arguments | |
| 115 PASS ReadableStream constructor can get initial garbage as cancel argument | |
| 116 PASS ReadableStream constructor can get initial garbage as pull argument | |
| 117 FAIL ReadableStream start should be called with the proper parameters assert_equ als: constructor should have 4 parameter expected 4 but got 5 | |
| 118 PASS ReadableStream start controller parameter should be extensible | |
| 119 PASS ReadableStream should be able to call start method within prototype chain o f its source | |
| 120 PASS ReadableStream start should be able to return a promise | |
| 121 PASS ReadableStream start should be able to return a promise and reject it | |
| 122 PASS ReadableStream should be able to enqueue different objects. | |
| 123 PASS ReadableStream: if pull rejects, it should error the stream | |
| 124 PASS ReadableStream: should only call pull once upon starting the stream | |
| 125 PASS ReadableStream: should call pull when trying to read from a started, empty stream | |
| 126 PASS ReadableStream: should only call pull once on a non-empty stream read from before start fulfills | |
| 127 PASS ReadableStream: should only call pull once on a non-empty stream read from after start fulfills | |
| 128 PASS ReadableStream: should call pull in reaction to read()ing the last chunk, i f not draining | |
| 129 PASS ReadableStream: should not call pull() in reaction to read()ing the last ch unk, if draining | |
| 130 PASS ReadableStream: should not call pull until the previous pull call's promise fulfills | |
| 131 PASS ReadableStream: should pull after start, and after every read | |
| 132 PASS ReadableStream: should not call pull after start if the stream is now close d | |
| 133 PASS ReadableStream: should call pull after enqueueing from inside pull (with no read requests), if strategy allows | |
| 134 PASS ReadableStream pull should be able to close a stream. | |
| 135 PASS ReadableStream pull should be able to error a stream. | |
| 136 PASS ReadableStream pull should be able to error a stream and throw. | |
| 137 PASS ReadableStream: enqueue should throw when the stream is readable but draini ng | |
| 138 PASS ReadableStream: enqueue should throw when the stream is closed | |
| 139 PASS ReadableStream: should call underlying source methods as methods | |
| 140 PASS ReadableStream strategies: the default strategy should give desiredSize of 1 to start, decreasing by 1 per enqueue | |
| 141 PASS ReadableStream strategies: the default strategy should continue giving desi redSize of 1 if the chunks are read immediately | |
| 142 PASS ReadableStream integration test: adapting a random push source | |
| 143 PASS ReadableStream integration test: adapting a sync pull source | |
| 144 PASS ReadableStream integration test: adapting an async pull source | |
| 145 Harness: the test ran to completion. | |
| 146 | |
| OLD | NEW |
