Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2500123002: Re-enable AppBannerManagerBrowserTests. (Closed)

Created:
4 years, 1 month ago by dominickn
Modified:
4 years, 1 month ago
Reviewers:
benwells
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable AppBannerManagerBrowserTests. This CL re-enables the disabled AppBannerManagerBrowserTests. Prior to landing, this has been run through 50 iterations on each of the Linux, Windows, and Mac trybots with no flakes observed. BUG=660798 TBR=benwells@chromium.org Committed: https://crrev.com/1a4d73beb118fed32cc6c53c78ec236e51a0ff32 Cr-Commit-Position: refs/heads/master@{#432244}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -22 lines) Patch
M chrome/browser/banners/app_banner_manager_browsertest.cc View 2 chunks +2 lines, -18 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2500123002/1
4 years, 1 month ago (2016-11-15 18:31:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-15 20:41:18 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 20:55:38 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a4d73beb118fed32cc6c53c78ec236e51a0ff32
Cr-Commit-Position: refs/heads/master@{#432244}

Powered by Google App Engine
This is Rietveld 408576698