Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2500113003: Fix inputs for main_dex_list action. (Closed)

Created:
4 years, 1 month ago by estevenson
Modified:
4 years, 1 month ago
Reviewers:
agrieve
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix inputs for main_dex_list action. BUG= Committed: https://crrev.com/237ee6948e7127d4d8e2022a63d26410d1080378 Cr-Commit-Position: refs/heads/master@{#432007}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add defined() check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M build/config/android/internal_rules.gni View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
estevenson
ptal Andrew, is this usage of "inputs" correct?
4 years, 1 month ago (2016-11-14 21:16:16 UTC) #2
agrieve
lgtm https://codereview.chromium.org/2500113003/diff/1/build/config/android/internal_rules.gni File build/config/android/internal_rules.gni (right): https://codereview.chromium.org/2500113003/diff/1/build/config/android/internal_rules.gni#newcode928 build/config/android/internal_rules.gni:928: inputs += [ main_dex_rules ] should also add ...
4 years, 1 month ago (2016-11-14 21:24:05 UTC) #3
agrieve
lgtm
4 years, 1 month ago (2016-11-14 21:24:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2500113003/20001
4 years, 1 month ago (2016-11-14 22:14:23 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-15 00:15:03 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 00:23:39 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/237ee6948e7127d4d8e2022a63d26410d1080378
Cr-Commit-Position: refs/heads/master@{#432007}

Powered by Google App Engine
This is Rietveld 408576698