Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4679)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/base/interactive_test_utils.cc

Issue 2500093003: Re-enable tabs_interactive_uitest for linux_aura (Closed)
Patch Set: merge with BringBrowserWindowToFront Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/test/base/interactive_test_utils.h ('K') | « chrome/test/base/interactive_test_utils.h ('k') | chrome/test/base/ui_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/interactive_test_utils.cc
diff --git a/chrome/test/base/interactive_test_utils.cc b/chrome/test/base/interactive_test_utils.cc
index e6681fbc986f4a061530b043a1d33ae2b5586372..41b5a10d38fd6cf74514ebd4d599bf2f7f662529 100644
--- a/chrome/test/base/interactive_test_utils.cc
+++ b/chrome/test/base/interactive_test_utils.cc
@@ -28,7 +28,12 @@ bool BringBrowserWindowToFront(const Browser* browser) {
if (!GetNativeWindow(browser, &window))
return false;
- return ui_test_utils::ShowAndFocusNativeWindow(window);
+ if (!ShowAndFocusNativeWindow(window))
+ return false;
+
+ BrowserActivationWaiter waiter(browser);
+ waiter.WaitForActivation();
+ return true;
}
bool SendKeyPressSync(const Browser* browser,
« chrome/test/base/interactive_test_utils.h ('K') | « chrome/test/base/interactive_test_utils.h ('k') | chrome/test/base/ui_test_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698