Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/base/interactive_test_utils.cc

Issue 2500093003: Re-enable tabs_interactive_uitest for linux_aura (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/extensions/api/tabs/tabs_interactive_test.cc ('K') | « chrome/test/base/interactive_test_utils.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/interactive_test_utils.cc
diff --git a/chrome/test/base/interactive_test_utils.cc b/chrome/test/base/interactive_test_utils.cc
index e6681fbc986f4a061530b043a1d33ae2b5586372..4928e7985909505f04c6afcdbb36a6f8ea02f8e4 100644
--- a/chrome/test/base/interactive_test_utils.cc
+++ b/chrome/test/base/interactive_test_utils.cc
@@ -23,6 +23,12 @@ bool GetNativeWindow(const Browser* browser, gfx::NativeWindow* native_window) {
} // namespace
+void ActivateBrowserWindow(Browser* browser) {
+ ASSERT_TRUE(BringBrowserWindowToFront(browser));
sky 2016/11/15 03:47:00 You should make ActivateBrowserWindow return a sta
Qiang(Joe) Xu 2016/11/15 16:25:30 Yes, I agree. Done.
+ BrowserActivationWaiter waiter(browser);
+ waiter.WaitForActivation();
+}
+
bool BringBrowserWindowToFront(const Browser* browser) {
gfx::NativeWindow window = NULL;
if (!GetNativeWindow(browser, &window))
« chrome/browser/extensions/api/tabs/tabs_interactive_test.cc ('K') | « chrome/test/base/interactive_test_utils.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698