chrome\browser\sync\engine\syncer_thread_timed_stop.h - Issue 250001: Second attempt at the new syncer thread impl, now with less crashes!...

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome\browser\sync\engine\syncer_thread_timed_stop.h

Issue 250001: Second attempt at the new syncer thread impl, now with less crashes!... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome\browser\sync\engine\syncer_thread_pthreads.cc ('k') | chrome\browser\sync\engine\syncer_thread_timed_stop.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4 //	4 //

5 // A class to run the syncer on a thread. This guy is the closest chrome-based	5 // A class to run the syncer on a thread. This guy is the closest chrome-based

6 // (as opposed to pthreads based) SyncerThread to the old pthread implementation	6 // (as opposed to pthreads based) SyncerThread to the old pthread implementation

7 // in semantics, as it supports a timeout on Stop() -- It is just an override of	7 // in semantics, as it supports a timeout on Stop() -- It is just an override of

8 // two methods from SyncerThread: ThreadMain and Stop -- to provide this.	8 // two methods from SyncerThread: ThreadMain and Stop -- to provide this.

9 #ifndef CHROME_BROWSER_SYNC_ENGINE_SYNCER_THREAD_TIMED_STOP_H_	9 #ifndef CHROME_BROWSER_SYNC_ENGINE_SYNCER_THREAD_TIMED_STOP_H_

10 #define CHROME_BROWSER_SYNC_ENGINE_SYNCER_THREAD_TIMED_STOP_H_	10 #define CHROME_BROWSER_SYNC_ENGINE_SYNCER_THREAD_TIMED_STOP_H_

(...skipping 33 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
44 // timed-wait for it to become false. For this and only this (temporary)	44 // timed-wait for it to become false. For this and only this (temporary)

45 // implementation, we protect this variable using our parent lock_.	45 // implementation, we protect this variable using our parent lock_.

46 bool in_thread_main_loop_;	46 bool in_thread_main_loop_;

47	47

48 DISALLOW_COPY_AND_ASSIGN(SyncerThreadTimedStop);	48 DISALLOW_COPY_AND_ASSIGN(SyncerThreadTimedStop);

49 };	49 };

50	50

51 } // namespace browser_sync	51 } // namespace browser_sync

52	52

53 #endif // CHROME_BROWSER_SYNC_ENGINE_SYNCER_THREAD_TIMED_STOP_H_	53 #endif // CHROME_BROWSER_SYNC_ENGINE_SYNCER_THREAD_TIMED_STOP_H_

OLD	NEW