Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Issue 2499943002: WritableStream: minor bug fixes (Closed)

Created:
4 years, 1 month ago by Adam Rice
Modified:
4 years, 1 month ago
Reviewers:
yhirano
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WritableStream: minor bug fixes * Constructing a WritableStream with a highWaterMark of NaN resulting in a TypeError. It should have been a RangeError. Fixed. * Constructing a WritableStreamDefaultController should fail if the WritableStream already had a controller. It did not. Fixed. BUG=658144 Committed: https://crrev.com/aff3d02ed430c9039ec2cc8b4f36f28687e2d6ce Cr-Commit-Position: refs/heads/master@{#432131}

Patch Set 1 #

Patch Set 2 : Combine conditions for invalid HWM exception #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M third_party/WebKit/Source/core/streams/WritableStream.js View 1 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2499943002/1
4 years, 1 month ago (2016-11-14 08:18:35 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-11-14 08:18:36 UTC) #4
Adam Rice
4 years, 1 month ago (2016-11-14 08:38:46 UTC) #8
yhirano
Are there any tests?
4 years, 1 month ago (2016-11-14 09:04:44 UTC) #9
Adam Rice
On 2016/11/14 09:04:44, yhirano wrote: > Are there any tests? Yes. The tests in https://codereview.chromium.org/2500833002/ ...
4 years, 1 month ago (2016-11-14 09:07:25 UTC) #10
yhirano
lgtm
4 years, 1 month ago (2016-11-15 03:17:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2499943002/20001
4 years, 1 month ago (2016-11-15 04:14:24 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-15 06:25:41 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 06:30:09 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aff3d02ed430c9039ec2cc8b4f36f28687e2d6ce
Cr-Commit-Position: refs/heads/master@{#432131}

Powered by Google App Engine
This is Rietveld 408576698