Expand aura::PropertyConverter support.

ui/aura/mus/property_converter.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_AURA_MUS_PROPERTY_CONVERTER_H_
 #define UI_AURA_MUS_PROPERTY_CONVERTER_H_
 
 #include <stdint.h>
 
+#include <map>
 #include <memory>
 #include <string>
 #include <vector>
 
 #include "base/macros.h"
 #include "ui/aura/aura_export.h"
+#include "ui/aura/window.h"
+
+namespace gfx {
+class Rect;
+}
 
 namespace aura {
 
-class Window;
-
 // PropertyConverter is used to convert Window properties for transport to the
 // mus window server and back. Any time a property changes from one side it is
 // mapped to the other using this class. Not all Window properties need to map
 // to server properties, and similarly not all transport properties need map to
 // Window properties.
 class AURA_EXPORT PropertyConverter {
  public:
   PropertyConverter();
-  virtual ~PropertyConverter();
+  ~PropertyConverter();
 
   // Maps a property on the Window to a property pushed to the server. Return
   // true if the property should be sent to the server, false if the property
   // is only used locally.
-  virtual bool ConvertPropertyForTransport(
+  bool ConvertPropertyForTransport(
       Window* window,
       const void* key,
       std::string* transport_name,
       std::unique_ptr<std::vector<uint8_t>>* transport_value);
 
   // Returns the transport name for a Window property.
-  virtual std::string GetTransportNameForPropertyKey(const void* key);
+  std::string GetTransportNameForPropertyKey(const void* key);
 
   // Applies a value from the server to |window|. |transport_name| is the
   // name of the property and |transport_data| the value. |transport_data| may
   // be null.
-  virtual void SetPropertyFromTransportValue(
+  void SetPropertyFromTransportValue(
       Window* window,
       const std::string& transport_name,
       const std::vector<uint8_t>* transport_data);
 
+  void RegisterPrimitiveProperty(const void* key,

[sky, 2016/11/16 17:56:13]

Document what |key| is. Or better yet, is it possible to define multiple
RegisterProperty() functions with the types are are supported? e.g.

RegisterProperty(const WindowProperty<bool>* property ..);
RegisterProperty(const WindowProperty<std::string*> property...);

?

[msw, 2016/11/16 22:47:45]

Done.

+                                 const char* aura_name,
+                                 const char* transport_name);
+  void RegisterRectProperty(const WindowProperty<gfx::Rect*>* property,
+                            const char* transport_name);
+  void RegisterStringProperty(const WindowProperty<std::string*>* property,
+                              const char* transport_name);
+
  private:
+  // A map of primitive property keys to their aura and mus property names.
+  typedef std::pair<const char*, const char*> PropertyNames;

[sky, 2016/11/16 17:56:13]

using?

[msw, 2016/11/16 22:47:45]

Done.

+  std::map<const void*, PropertyNames> primitive_properties_;

[sky, 2016/11/16 17:56:13]

Document what the key is as it isn't readily obvious what the key is here.

[msw, 2016/11/16 22:47:45]

Done.

+
+  // Maps of some aura window properties to their mus property names.
+  std::map<const WindowProperty<gfx::Rect*>*, const char*> rect_properties_;
+  std::map<const WindowProperty<std::string*>*, const char*> string_properties_;
+
   DISALLOW_COPY_AND_ASSIGN(PropertyConverter);
 };
 
 }  // namespace aura
 
 #endif  // UI_AURA_MUS_PROPERTY_CONVERTER_H_