Remove ArcAuthService::GetAuthCodeDeprecated0() implementation.

Remove ArcAuthService::GetAuthCodeDeprecated0() implementation.

The method is no longer used. With this CL, the implementation
is removed.

BUG=657687
BUG=b/31079732
TEST=Trybots.

Committed: https://crrev.com/60e845bca3f291f751495b1ae9f119acd1bccae7
Cr-Commit-Position: refs/heads/master@{#432005}

[hidehiko, 2016-11-14 07:39:31]

The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 07:39:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hidehiko, 2016-11-14 07:41:03]

hidehiko@chromium.org changed reviewers:
+ lhchavez@chromium.org

[hidehiko, 2016-11-14 07:41:03]

Extracted from crrev.com/2490093002/

PTAL.

https://codereview.chromium.org/2499933002/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/arc_auth_service.cc (right):

https://codereview.chromium.org/2499933002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_auth_service.cc:357:
callback.Run(std::string());
Because this should never be called, we may be able to drop "just in case
callback.Run()" here?

[commit-bot: I haz the power, 2016-11-14 08:04:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 08:04:42]

Dry run: This issue passed the CQ dry run.

[Luis Héctor Chávez, 2016-11-14 16:07:52]

lgtm

https://codereview.chromium.org/2499933002/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/arc_auth_service.cc (right):

https://codereview.chromium.org/2499933002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_auth_service.cc:357:
callback.Run(std::string());
On 2016/11/14 07:41:03, hidehiko wrote:
> Because this should never be called, we may be able to drop "just in case
> callback.Run()" here?

yeah, we should drop it.

[hidehiko, 2016-11-14 17:54:51]

Thank you for review. Submitting.

https://codereview.chromium.org/2499933002/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/arc_auth_service.cc (right):

https://codereview.chromium.org/2499933002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_auth_service.cc:357:
callback.Run(std::string());
On 2016/11/14 16:07:52, Luis Héctor Chávez wrote:
> On 2016/11/14 07:41:03, hidehiko wrote:
> > Because this should never be called, we may be able to drop "just in case
> > callback.Run()" here?
> 
> yeah, we should drop it.

Done.

[hidehiko, 2016-11-14 17:54:55]

The CQ bit was checked by hidehiko@chromium.org

[hidehiko, 2016-11-14 17:54:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
lhchavez@chromium.org
Link to the patchset: https://codereview.chromium.org/2499933002/#ps20001
(title: "Address comment.")

[commit-bot: I haz the power, 2016-11-14 17:55:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 00:13:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-15 00:14:51]

Description was changed from

==========
Remove ArcAuthService::GetAuthCodeDeprecated0() implementation.

The method is no longer used. With this CL, the implementation
is removed.

BUG=657687
BUG=b/31079732
TEST=Trybots.
==========

to

==========
Remove ArcAuthService::GetAuthCodeDeprecated0() implementation.

The method is no longer used. With this CL, the implementation
is removed.

BUG=657687
BUG=b/31079732
TEST=Trybots.

Committed: https://crrev.com/60e845bca3f291f751495b1ae9f119acd1bccae7
Cr-Commit-Position: refs/heads/master@{#432005}
==========

[commit-bot: I haz the power, 2016-11-15 00:14:52]

Patchset 2 (id:??) landed as
https://crrev.com/60e845bca3f291f751495b1ae9f119acd1bccae7
Cr-Commit-Position: refs/heads/master@{#432005}