Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2499923003: Disable access to secondary dex files. (Closed)

Created:
4 years, 1 month ago by estevenson
Modified:
3 years, 5 months ago
Reviewers:
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable access to secondary dex files. This CL contains a check to make sure that secondary dex files aren't accessed by isolated processes (in debug only). This should catch new occurences of classes that need to be in the main dex file not ending up in the main dex list. BUG=657024

Patch Set 1 #

Patch Set 2 : Findbugs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -179 lines) Patch
M base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + base/android/java/src/org/chromium/base/Reflect.java View 1 11 chunks +25 lines, -13 lines 0 comments Download
M base/android/java/src/org/chromium/base/multidex/ChromiumMultiDexInstaller.java View 1 4 chunks +46 lines, -23 lines 0 comments Download
M base/android/java/templates/BuildConfig.template View 1 chunk +13 lines, -0 lines 0 comments Download
M build/android/incremental_install/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M build/android/incremental_install/java/org/chromium/incrementalinstall/BootstrapApplication.java View 1 chunk +2 lines, -0 lines 0 comments Download
M build/android/incremental_install/java/org/chromium/incrementalinstall/ClassLoaderPatcher.java View 1 chunk +2 lines, -0 lines 0 comments Download
D build/android/incremental_install/java/org/chromium/incrementalinstall/Reflect.java View 1 chunk +0 lines, -142 lines 0 comments Download
M build/config/android/rules.gni View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (8 generated)
estevenson
The CQ bit was checked by estevenson@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-14 21:22:25 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2499923003/1
4 years, 1 month ago (2016-11-14 21:23:37 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-14 22:57:31 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/163893)
4 years, 1 month ago (2016-11-14 22:57:31 UTC) #4
estevenson
The CQ bit was checked by estevenson@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-14 23:10:52 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2499923003/20001
4 years, 1 month ago (2016-11-14 23:12:37 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-15 00:49:38 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 00:49:39 UTC) #8
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698