Update dromaeo to upstream a876d5250befbc41e2deab9d10cf6085b511d5ed

chrome/test/data/dromaeo/webrunner.js

 (function(){
         
         // Populated from: http://www.medcalc.be/manual/t-distribution.php
         // 95% confidence for N - 1 = 4
         var tDistribution = 2.776;
         
         // The number of individual test iterations to do
         var numTests = 5;
         
         // The type of run that we're doing (options are "runs/s" or "ms")
@@ skipping 130 matching lines @@
                                         data.scale = num;
                                                                 
                                         logTest(data);
                         
                                         dequeue();
                                 }
                         }, 1);
                 });
 
                 function compute(times, runs){
-                        var results = {runs: runs}, num = times.length;
+                        var results = {runs: runs}, num = times.length, middle = num/2;
 
                         times = times.sort(function(a,b){
                                 return a - b;
                         });
 
                         // Make Sum
                         results.sum = 0;
 
                         for ( var i = 0; i < num; i++ )
                                 results.sum += times[i];
 
                         // Make Min
                         results.min = times[0];
                                           
                         // Make Max
                         results.max = times[ num - 1 ];
 
                         // Make Mean
                         results.mean = results.sum / num;
                         
                         // Make Median
                         results.median = num % 2 == 0 ?
-                                (times[Math.floor(num/2)] + times[Math.ceil(num/2)]) / 2 :
-                                times[Math.round(num/2)];
+                                (times[middle-1] + times[middle]) / 2 :
+                                times[Math.floor(middle)];
                         
                         // Make Variance
                         results.variance = 0;
 
                         for ( var i = 0; i < num; i++ )
                                 results.variance += Math.pow(times[i] - results.mean, 2);
 
                         results.variance /= num - 1;
                                         
                         // Make Standard Deviation
@@ skipping 37 matching lines @@
         var testDone = {};
         var testNames = {};
         var testVersions = {};
         var dataStore = [];
         var names = [];
         var interval;
         var totalTime = 0;
         var time = 0;
         var title, testName, testID, testSummary = {} , testSummaryNum = {}, maxTotal = 0, maxTotalNum = 0;
         var nameDone = {};
-        var automated = false;
-        var post_json = false;
         
         // Query String Parsing
         var search = window.limitSearch || (window.location.search || "?").substr(1);
 
         search = search.replace(/&runStyle=([^&]+)/, function(all, type){
                 runStyle = type;
                 return "";
         });
 
         var parts = search.split("&");
@@ skipping 19 matching lines @@
                                 var sharkMatch = new RegExp(m[1]);
                                 doShark = function(name) {
                                         return sharkMatch.test(name);
                                 };
                         }
                 }
 
                 m = /^numTests=(\d+)$/.exec(parts[i]);
                 if (m)
                         numTests = Number(m[1]);
-
-                if (/^automated$/.exec(parts[i]))
-                        automated = true;
-                if (/^post_json$/.exec(parts[i]))
-                        post_json = true;
         }
 
         jQuery(function(){
                 var id = search.match(/id=([\d,]+)/);
 
                 if ( none && !id ) {
                         $("#overview").hide();
                         return;
                 } 
 
@@ skipping 88 matching lines @@
                                         pre.style.display = "none";
                                         pre.innerHTML = "__start_report" + summary + "__end_report";
                                         document.body.appendChild( pre );
                                 }
 
                                 if ( typeof goQuitApplication !== "undefined" ) {
                                         goQuitApplication();
                                 }
         
                         } else if ( dataStore && dataStore.length ) {
-                                if (!automated) {
-                                        $("body").addClass("alldone");
-                                        var div = jQuery("<div class='results'>Saving...</div>").insertBefore("#overview");
-                                        jQuery.ajax({
-                                                type: "POST",
-                                                url: "store.php",
-                                                data: "data=" + encodeURIComponent(JSON.stringify(dataStore)) + "&style=" + runStyle,
-                                                success: function(id){
-                                                        var url = window.location.href.replace(/\?.*$/, "") + "?id=" + id;
-                                                        div.html("Results saved. You can access them at a later time at the following URL:<br/><strong><a href='" + url + "'>" + url + "</a></strong></div>");
-                                                }
-                                        });
-                                } else if (post_json) {
-                                        jQuery.ajax({
-                                                type: "POST",
-                                                url: "store.php",
-                                                data: "data=" + encodeURIComponent(JSON.stringify(window.automation.GetResults()))
-                                        });
-                                }
-                                else {
-                                        window.automation.SetDone();
-                                }
+                                $("body").addClass("alldone");
+                                var div = jQuery("<div class='results'>Saving...</div>").insertBefore("#overview");
+                                jQuery.ajax({
+                                        type: "POST",
+                                        url: "store.php",
+                                        data: "data=" + encodeURIComponent(JSON.stringify(dataStore)) + "&style=" + runStyle,
+                                        success: function(id){
+                                                var url = window.location.href.replace(/\?.*$/, "") + "?id=" + id;
+                                                div.html("Results saved. You can access them at a later time at the following URL:<br/><strong><a href='" + url + "'>" + url + "</a></strong></div>");
+                                        }
+                                });
                         }
                 }
         }
         
         function updateTimebar(){
                 $("#timebar").html("<span><strong>" + (runStyle === "runs/s" ? Math.pow(Math.E, maxTotal / maxTotalNum) : maxTotal).toFixed(2) + "</strong>" + runStyle + " (Total)</span>");
         }
         
         // Run once all the test files are fully loaded
         function init(){
                 for ( var n = 0; n < names.length; n++ ) {
                         queue = queue.concat( queues[ names[n] ] );
                 }
 
                 totalTime = time;
                 time += timePerTest;
                 updateTime();
                 
-                if (!automated) {
-                        $("#pause")
-                                .val("Run")
-                                .click(function(){
-                                        if ( interval ) {
-                                                interval = null;
-                                                this.value = "Run";
-                                        } else {
-                                                if ( !interval ) {
-                                                        interval = true;
-                                                        dequeue();
-                                                }
-                                                this.value = "Pause";
+                $("#pause")
+                        .val("Run")
+                        .click(function(){
+                                if ( interval ) {
+                                        interval = null;
+                                        this.value = "Run";
+                                } else {
+                                        if ( !interval ) {
+                                                interval = true;
+                                                dequeue();
                                         }
-                                });
-                } else {
-                        $("#pause")
-                                .val("Automated")
-                                .click(function(){});
-                        interval = true;
-                        dequeue();
-                }
+                                        this.value = "Pause";
+                                }
+                        });
 
                 if ( window.limitSearch ) {
                         $("#pause").click();
                 }
         }
 
         function initTest(curID){
                 $("<div class='result-item'></div>")
                         .append( testElems[ curID ] )
                         .append( "<p>" + (tests[curID] ? tests[ curID ].desc : "") + "<br/><a href='" + 
@@ skipping 338 matching lines @@
                 testElems[testID] = $("<div class='test'></div>")
                         .click(function(){
                                 var next = jQuery(this).next().next();
                                 if ( next.children().length == 0 ) return;
                                 var display = next.css("display");
                                 next.css("display", display == 'none' ? 'block' : 'none');
                         });
 
                 updateTestPos({curID: testID, collection: tests[testID] ? tests[testID].name : testID, version: testVersions[testID]}, true);
         }
-
-        if (automated) {
-                // Add some more stuff if running in automated mode.

[Nico, 2016/11/14 22:20:58]

we're not using this, yes?

[dvallet, 2016/11/15 02:19:38]

Not really sure, it seems like it just adds some extra stuff, but I'm not sure
if in tests automated == true.

[Nico, 2016/11/15 15:30:06]

The readme says "This benchmark was slightly modified to enable Chromium
automation.", so I'm wondering if this might be that.

Have you tried diffing the current in-tree dromaeo to the upstream dromaeo from
around the same time? (asargent, I don't suppose you remember anything about
this?)

[dvallet, 2016/11/15 23:18:05]

I'm fairly certain that the automation bit was added in chromium only. E.g.,
this is the version that was used to do the last update:
https://github.com/jeresig/dromaeo/blob/776f3b1c61f4b025f25bc40c34ff42ee244cc...

My suggestion then is leave the automation here, but include the fix introduced
in
https://github.com/jeresig/dromaeo/commit/31de794e53bf69990660f52751b859fc52d...

-                window.automation = {}
-                window.automation.SetDone = function() {
-                        console.log("Total: " + this.GetScore());
-                        window.document.cookie = "__done=1; path=/";
-                }
-                window.automation.GetScore = function() {
-                        return (runStyle === "runs/s" ? Math.pow(Math.E, maxTotal / maxTotalNum) : maxTotal).toString();
-                }
-                window.automation.GetResults = function() {
-                        var results = {};
-                        var aggregated = {};
-                        function normalizeName(name) {
-                                // At least for ui_tests, dots are not allowed.
-                                return name.replace(".", "_");
-                        }
-                        function appendToAggregated(name, value) {
-                                name = normalizeName(name);
-                                (aggregated[name] || (aggregated[name] = [])).push(Math.log(value));
-                        }
-
-                        for (var i = 0; i < dataStore.length; i++) {
-                                var data = dataStore[i];
-                                var topName = data.collection.split("-", 1)[0];
-                                appendToAggregated(topName, data.mean);
-                                appendToAggregated(data.collection, data.mean);
-                                results[normalizeName(data.collection + "/" + data.name)] = data.mean.toString();
-                        }
-
-                        for (var name in aggregated) {
-                                var means = aggregated[name];
-                                var sum = 0;
-                                for (var i = 0; i < means.length; i++) sum += means[i];
-                                results[name] = Math.pow(Math.E, sum/means.length).toString();
-                        }
-
-                        return results;
-                }
-        }
 })();