Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Issue 24999007: Avoid allocations in Object.observe access check tests (Closed)

Created:
7 years, 2 months ago by adamk
Modified:
7 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev, rafaelw, rossberg
Visibility:
Public.

Description

Avoid allocations in Object.observe access check tests BUG=v8:2907 R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17090

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -34 lines) Patch
M test/cctest/cctest.status View 1 chunk +0 lines, -5 lines 0 comments Download
M test/cctest/test-object-observe.cc View 7 chunks +26 lines, -29 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
adamk
7 years, 2 months ago (2013-09-27 20:14:03 UTC) #1
Michael Starzinger
LGTM.
7 years, 2 months ago (2013-09-30 11:27:11 UTC) #2
adamk
7 years, 2 months ago (2013-10-02 18:06:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17090 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698