Issue 24999002: lazy instantiation of the default isolate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24999002: lazy instantiation of the default isolate (Closed)

Created:
7 years, 2 months ago by dcarney

Modified:
7 years, 2 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

lazy instantiation of the default isolate this cl also moves all accesses to the default isolate behind EnsureDefaultIsolate R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=17049

Patch Set 1 #

Total comments: 1

Patch Set 2 : nit #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -39 lines)			Patch
M	src/api.cc	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download
M	src/isolate.h	View	1	4 chunks	+14 lines, -4 lines	0 comments	Download
M	src/isolate.cc	View	1	8 chunks	+40 lines, -23 lines	0 comments	Download
M	src/v8.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/v8.cc	View	1	2 chunks	+16 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM. https://codereview.chromium.org/24999002/diff/1/src/isolate.h File src/isolate.h (right): https://codereview.chromium.org/24999002/diff/1/src/isolate.h#newcode1254 src/isolate.h:1254: bool is_default_isolate_; nit: Let's move this down to ...

7 years, 2 months ago (2013-10-01 14:19:08 UTC) #2

dcarney

7 years, 2 months ago (2013-10-01 14:27:12 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r17049 (presubmit successful).

Expand Messages | Collapse Messages