Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2499893002: Fix virtual/mojo-loading test expecations (Closed)

Created:
4 years, 1 month ago by yhirano
Modified:
4 years, 1 month ago
Reviewers:
tzik
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix virtual/mojo-loading test expecations Based on the flakiness dashboard, some tests are not flaky. I also added some newly found flaky tests and relabeled existing ones. BUG=659917, 420240, 664874 Committed: https://crrev.com/176c99dded39646185359db261f15b7eaef9b558 Cr-Commit-Position: refs/heads/master@{#431832}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -29 lines) Patch
M third_party/WebKit/LayoutTests/LeakExpectations View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/SlowTests View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 3 chunks +4 lines, -29 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
yhirano
Can you double-check with http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=mojo-loading ?
4 years, 1 month ago (2016-11-14 04:37:51 UTC) #7
tzik
lgtm
4 years, 1 month ago (2016-11-14 04:58:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2499893002/1
4 years, 1 month ago (2016-11-14 04:59:58 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 05:04:24 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 05:05:52 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/176c99dded39646185359db261f15b7eaef9b558
Cr-Commit-Position: refs/heads/master@{#431832}

Powered by Google App Engine
This is Rietveld 408576698