Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 2499883002: Media Controls: handle 'timeupdate', 'play' and 'pause' via an EventListener. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/shadow/MediaControls.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
index 833fef54fe0611793710a84245bee3cf1008c16a..ffa3497917e492c92590259af75b85f4cf7e651a 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
@@ -2512,9 +2512,6 @@ void HTMLMediaElement::playbackProgressTimerFired(TimerBase*) {
if (!playbackRate())
return;
- if (!m_paused && mediaControls())
whywhat 2016/11/15 02:51:08 This seems to only be called when !m_paused but sc
- mediaControls()->playbackProgressed();
-
cueTimeline().updateActiveCues(currentTime());
}
@@ -3326,11 +3323,8 @@ void HTMLMediaElement::updatePlayState() {
m_autoplayHelper->playbackStarted();
}
- if (mediaControls())
- mediaControls()->playbackStarted();
startPlaybackProgressTimer();
m_playing = true;
-
} else { // Should not be playing right now
if (isPlaying) {
webMediaPlayer()->pause();
@@ -3342,9 +3336,6 @@ void HTMLMediaElement::updatePlayState() {
double time = currentTime();
if (time > m_lastSeekTime)
addPlayedRange(m_lastSeekTime, time);
-
- if (mediaControls())
- mediaControls()->playbackStopped();
}
if (layoutObject())
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/shadow/MediaControls.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698