Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 2499883002: Media Controls: handle 'timeupdate', 'play' and 'pause' via an EventListener. (Closed)

Created:
4 years, 1 month ago by mlamouri (slow - plz ping)
Modified:
4 years ago
Reviewers:
whywhat
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, nessy, Srirama, vcarbune.chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Media Controls: handle 'timeupdate', 'play' and 'pause' via an EventListener. Instead of having hard coded plumbing from HTMLMediaElement to MediaControls. BUG=662761 Committed: https://crrev.com/88ea177babd78b83478c082a903c45e8b3499703 Cr-Commit-Position: refs/heads/master@{#435220}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Patch Set 3 : test fixes #

Patch Set 4 : fix repaint test #

Messages

Total messages: 28 (18 generated)
mlamouri (slow - plz ping)
4 years, 1 month ago (2016-11-13 06:36:12 UTC) #4
DaleCurtis
\o/
4 years, 1 month ago (2016-11-14 18:48:04 UTC) #7
whywhat
lgtm https://codereview.chromium.org/2499883002/diff/1/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (left): https://codereview.chromium.org/2499883002/diff/1/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp#oldcode2515 third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:2515: if (!m_paused && mediaControls()) This seems to only ...
4 years, 1 month ago (2016-11-15 02:51:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2499883002/40001
4 years ago (2016-11-29 21:47:18 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on ...
4 years ago (2016-11-29 23:49:40 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2499883002/40001
4 years ago (2016-11-30 00:23:53 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/344657)
4 years ago (2016-11-30 01:54:37 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2499883002/60001
4 years ago (2016-11-30 09:56:05 UTC) #24
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-11-30 11:39:35 UTC) #26
commit-bot: I haz the power
4 years ago (2016-11-30 11:41:55 UTC) #28
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/88ea177babd78b83478c082a903c45e8b3499703
Cr-Commit-Position: refs/heads/master@{#435220}

Powered by Google App Engine
This is Rietveld 408576698