Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2499863002: Simplify content_layer attachment and viewporting logic. (Closed)

Created:
4 years, 1 month ago by aelias_dont_use
Modified:
4 years ago
CC:
chromium-reviews, mdjones
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify content_layer attachment and viewporting logic. I noticed a lot of complex logic in content_layer.cc and static_tab_scene_layer.cc that appears to do nothing useful anymore. I simplified it by: 1) Always detaching and reattaching the live and static sublayers instead of trying to preserve the existing structure. (There shouldn't be any performance cost to this.) 2) Following a much simpler policy for positioning and clipping. I compared the behavior of the old and new logic in a variety of device rotation, tab switcher and URL-bar-hiding scenarios, and I haven't yet observed any regression. BUG=662427

Patch Set 1 #

Patch Set 2 : Add should_clip #

Patch Set 3 : Fix clang error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -187 lines) Patch
M chrome/browser/android/compositor/layer/content_layer.h View 1 2 3 chunks +5 lines, -15 lines 0 comments Download
M chrome/browser/android/compositor/layer/content_layer.cc View 1 2 3 chunks +30 lines, -135 lines 0 comments Download
M chrome/browser/android/compositor/layer/tab_layer.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/android/compositor/layer/thumbnail_layer.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/android/compositor/layer/thumbnail_layer.cc View 1 3 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/android/compositor/scene_layer/static_tab_scene_layer.cc View 1 2 chunks +4 lines, -34 lines 0 comments Download

Messages

Total messages: 15 (12 generated)
aelias_OOO_until_Jul13
Hi changwan@, PTAL.
4 years, 1 month ago (2016-11-12 23:31:03 UTC) #7
aelias_OOO_until_Jul13
I found a tablet-specific bug with this, so please hold off review for now.
4 years, 1 month ago (2016-11-13 04:24:30 UTC) #14
aelias_OOO_until_Jul13
4 years ago (2016-12-09 23:47:03 UTC) #15
Message was sent while issue was closed.
Closing this issue because I accidentally created it as aelias@google.com,
created another issue at https://codereview.chromium.org/2566753004

Powered by Google App Engine
This is Rietveld 408576698