Chromium Code Reviews
DescriptionSimplify content_layer attachment and viewporting logic.
I noticed a lot of complex logic in content_layer.cc and
static_tab_scene_layer.cc that appears to do nothing useful anymore. I
simplified it by:
1) Always detaching and reattaching the live and static sublayers
instead of trying to preserve the existing structure. (There shouldn't
be any performance cost to this.)
2) Following a much simpler policy for positioning and clipping. I
compared the behavior of the old and new logic in a variety of device
rotation, tab switcher and URL-bar-hiding scenarios, and I haven't
yet observed any regression.
BUG=662427
Patch Set 1 #Patch Set 2 : Add should_clip #Patch Set 3 : Fix clang error #
Messages
Total messages: 15 (12 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||