third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp - Issue 2499853002: Fixed clip resize for document.rootScroller with inertTopControls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

Issue 2499853002: Fixed clip resize for document.rootScroller with inertTopControls (Closed)

Patch Set: +Test Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp ('k') | third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.h » ('j') | third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

index 1c567e638d648337bec4ec130acd580c7f999139..5c51407037f542945f78277e5854b6c71ba00aa7 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

@@ -239,6 +239,12 @@ void CompositingInputsUpdater::updateRecursive(PaintLayer* layer,

if (layer->layoutObject()->hasClipPath())

info.hasAncestorWithClipPath = true;

+ layer->setIsRootScroller(layer ==

+ layer->layoutObject()

+ ->document()

+ .rootScrollerController()

+ ->rootScrollerPaintLayer());

bool hasDescendantWithClipPath = false;

bool hasNonIsolatedDescendantWithBlendMode = false;

bool hasRootScrollerAsDescendant = false;

@@ -246,12 +252,8 @@ void CompositingInputsUpdater::updateRecursive(PaintLayer* layer,

child = child->nextSibling()) {

updateRecursive(child, updateType, info);

- hasRootScrollerAsDescendant |= child->hasRootScrollerAsDescendant() ||

- (child ==

- child->layoutObject()

- ->document()

- .rootScrollerController()

- ->rootScrollerPaintLayer());

+ hasRootScrollerAsDescendant |=

+ child->hasRootScrollerAsDescendant() || child->isRootScroller();

hasDescendantWithClipPath |= child->hasDescendantWithClipPath() ||

child->layoutObject()->hasClipPath();

hasNonIsolatedDescendantWithBlendMode |=