third_party/WebKit/Source/web/tests/VisualViewportTest.cpp - Issue 2499853002: Fixed clip resize for document.rootScroller with inertTopControls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

Issue 2499853002: Fixed clip resize for document.rootScroller with inertTopControls (Closed)

Patch Set: Addressed feedback Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

index 26d508ee564501d5b14eaf35506be95f50cdaea7..3c40abf5eeac55fe8ef80d156e2a7f0e6e264c6e 100644

--- a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

+++ b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

@@ -2374,6 +2374,8 @@ TEST_P(VisualViewportTest, ResizeNonFixedBackgroundNoLayoutOrInvalidation) {

isSubtree);

EXPECT_EQ(0u, needsLayoutObjects);

+ webViewImpl->updateAllLifecyclePhases();

// Do a real resize to check for invalidations.

document->view()->setTracksPaintInvalidations(true);

webViewImpl->resizeWithBrowserControls(WebSize(pageWidth, smallestHeight),