Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 2499853002: Fixed clip resize for document.rootScroller with inertTopControls (Closed)
Patch Set: Addressed feedback Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 (C) 1998 Waldo Bastian (bastian@kde.org) 3 (C) 1998 Waldo Bastian (bastian@kde.org)
4 (C) 1998, 1999 Torben Weis (weis@kde.org) 4 (C) 1998, 1999 Torben Weis (weis@kde.org)
5 (C) 1999 Lars Knoll (knoll@kde.org) 5 (C) 1999 Lars Knoll (knoll@kde.org)
6 (C) 1999 Antti Koivisto (koivisto@kde.org) 6 (C) 1999 Antti Koivisto (koivisto@kde.org)
7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights 7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights
8 reserved. 8 reserved.
9 9
10 This library is free software; you can redistribute it and/or 10 This library is free software; you can redistribute it and/or
(...skipping 396 matching lines...) Expand 10 before | Expand all | Expand 10 after
407 void invalidatePaintForTickmarks(); 407 void invalidatePaintForTickmarks();
408 408
409 // Since the compositor can resize the viewport due to browser controls and 409 // Since the compositor can resize the viewport due to browser controls and
410 // commit scroll offsets before a WebView::resize occurs, we need to adjust 410 // commit scroll offsets before a WebView::resize occurs, we need to adjust
411 // our scroll extents to prevent clamping the scroll offsets. 411 // our scroll extents to prevent clamping the scroll offsets.
412 void setBrowserControlsViewportAdjustment(float); 412 void setBrowserControlsViewportAdjustment(float);
413 IntSize browserControlsSize() const { 413 IntSize browserControlsSize() const {
414 return IntSize(0, ceilf(m_browserControlsViewportAdjustment)); 414 return IntSize(0, ceilf(m_browserControlsViewportAdjustment));
415 } 415 }
416 416
417 PaintLayer* layer() const override;
chrishtr 2016/11/19 01:10:26 Move this down next to the other methods for the S
bokan 2016/11/19 20:03:47 Done.
418
417 IntSize maximumScrollOffsetInt() const override; 419 IntSize maximumScrollOffsetInt() const override;
418 420
419 // ScrollableArea interface 421 // ScrollableArea interface
420 void getTickmarks(Vector<IntRect>&) const override; 422 void getTickmarks(Vector<IntRect>&) const override;
421 IntRect scrollableAreaBoundingBox() const override; 423 IntRect scrollableAreaBoundingBox() const override;
422 bool scrollAnimatorEnabled() const override; 424 bool scrollAnimatorEnabled() const override;
423 bool usesCompositedScrolling() const override; 425 bool usesCompositedScrolling() const override;
424 bool shouldScrollOnMainThread() const override; 426 bool shouldScrollOnMainThread() const override;
425 GraphicsLayer* layerForScrolling() const override; 427 GraphicsLayer* layerForScrolling() const override;
426 GraphicsLayer* layerForHorizontalScrollbar() const override; 428 GraphicsLayer* layerForHorizontalScrollbar() const override;
(...skipping 722 matching lines...) Expand 10 before | Expand all | Expand 10 after
1149 widget.isFrameView()); 1151 widget.isFrameView());
1150 DEFINE_TYPE_CASTS(FrameView, 1152 DEFINE_TYPE_CASTS(FrameView,
1151 ScrollableArea, 1153 ScrollableArea,
1152 scrollableArea, 1154 scrollableArea,
1153 scrollableArea->isFrameView(), 1155 scrollableArea->isFrameView(),
1154 scrollableArea.isFrameView()); 1156 scrollableArea.isFrameView());
1155 1157
1156 } // namespace blink 1158 } // namespace blink
1157 1159
1158 #endif // FrameView_h 1160 #endif // FrameView_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698