Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 24998005: unicode-bidi: plaintext does not work properly when a line wraps (Closed)

Created:
7 years, 2 months ago by igoroliveira
Modified:
7 years, 2 months ago
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

unicode-bidi: plaintext never worked properly when there is a line wrapping in a span with unicode-bidi: plaintext. The problem happens because constructBidiRunsForSegment does not have enough logic to understand the difference between line wrapping vs line breaking, the current patch just adds the necessary logic(e.g when a text has a line wrapping it needs to determine the directionality of the paragraph from the beginning of the isolatedInline) BUG=299879 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158471

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -8 lines) Patch
A LayoutTests/fast/text/international/unicode-bidi-plaintext-line-wrap.html View 1 chunk +37 lines, -0 lines 0 comments Download
A LayoutTests/fast/text/international/unicode-bidi-plaintext-line-wrap-expected.html View 1 chunk +33 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBlockLineLayout.cpp View 5 chunks +11 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
igoroliveira
7 years, 2 months ago (2013-09-27 18:52:57 UTC) #1
leviw_travelin_and_unemployed
Great! LGTM.
7 years, 2 months ago (2013-09-27 19:44:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/igor.o@sisa.samsung.com/24998005/1
7 years, 2 months ago (2013-09-27 19:45:09 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-09-27 22:35:56 UTC) #4
Message was sent while issue was closed.
Change committed as 158471

Powered by Google App Engine
This is Rietveld 408576698