Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 24998004: Move unlikely-to-be-inlined code from SkPathRef.h to SkPathRef.cpp (Closed)

Created:
7 years, 2 months ago by robertphillips
Modified:
7 years, 2 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Making SkPathRef.h a bit lighter-weight prior to next transfer of member variables from SkPath to SkPathRef.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Moved some methods back to .h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+313 lines, -291 lines) Patch
M include/core/SkPathRef.h View 1 11 chunks +14 lines, -248 lines 0 comments Download
M src/core/SkPathRef.cpp View 1 4 chunks +299 lines, -43 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
robertphillips
7 years, 2 months ago (2013-09-27 15:34:47 UTC) #1
bsalomon
https://codereview.chromium.org/24998004/diff/1/include/core/SkPathRef.h File include/core/SkPathRef.h (left): https://codereview.chromium.org/24998004/diff/1/include/core/SkPathRef.h#oldcode89 include/core/SkPathRef.h:89: void grow(int newVerbs, int newPts, uint8_t** verbs, SkPoint** pts) ...
7 years, 2 months ago (2013-09-27 15:58:51 UTC) #2
robertphillips
This patch moves the two 'grow' methods back to the header. https://codereview.chromium.org/24998004/diff/1/include/core/SkPathRef.h File include/core/SkPathRef.h (left): ...
7 years, 2 months ago (2013-09-27 16:13:30 UTC) #3
bsalomon
lgtm
7 years, 2 months ago (2013-09-27 17:38:17 UTC) #4
robertphillips
7 years, 2 months ago (2013-09-27 17:49:07 UTC) #5
Message was sent while issue was closed.
committed as r11506

Powered by Google App Engine
This is Rietveld 408576698