Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2499743002: Removing ChildProcessHostMsg_SyncAllocateSharedMemory IPC message. (Closed)

Created:
4 years, 1 month ago by Jay Civelli
Modified:
4 years, 1 month ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Relanding https://codereview.chromium.org/2478343002/ It was breaking some blink tests as the Mojo buffers had a maximum size that base::SharedMemory does not have. That max size was removed in https://codereview.chromium.org/2488253003 and the tests now pass. BUG=612500 Committed: https://crrev.com/f1b03de69bfc005873519372c2f0afbc58093d77 Cr-Commit-Position: refs/heads/master@{#432737}

Patch Set 1 #

Patch Set 2 : synced #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -81 lines) Patch
M content/browser/renderer_host/render_message_filter.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 2 chunks +3 lines, -23 lines 0 comments Download
M content/child/child_thread_impl.cc View 2 chunks +16 lines, -18 lines 0 comments Download
M content/common/child_process_host_impl.h View 1 2 chunks +0 lines, -7 lines 0 comments Download
M content/common/child_process_host_impl.cc View 1 3 chunks +3 lines, -24 lines 0 comments Download
M content/common/child_process_messages.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 32 (18 generated)
Jay Civelli
4 years, 1 month ago (2016-11-11 22:10:05 UTC) #3
Jay Civelli
Adding @pfeldman as OWNER reviewer since @nasko (original reviewer) is OOO. This is a re-land ...
4 years, 1 month ago (2016-11-11 23:44:36 UTC) #9
Jay Civelli
Friendly ping.
4 years, 1 month ago (2016-11-15 18:20:01 UTC) #10
Jay Civelli
Adding @avi for content OWNER review Thanks!
4 years, 1 month ago (2016-11-16 19:24:48 UTC) #13
Avi (use Gerrit)
lgtm stamp
4 years, 1 month ago (2016-11-16 19:46:19 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2499743002/1
4 years, 1 month ago (2016-11-16 21:20:33 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/107090) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 1 month ago (2016-11-16 21:24:39 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2499743002/20001
4 years, 1 month ago (2016-11-16 22:35:11 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/306202)
4 years, 1 month ago (2016-11-16 23:21:11 UTC) #23
Jay Civelli
Adding @tsepez for content/common/child_process_messages.h OWNER review. Thanks.
4 years, 1 month ago (2016-11-16 23:56:07 UTC) #25
Tom Sepez
RS LGTM on deleting message.
4 years, 1 month ago (2016-11-17 00:01:11 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2499743002/20001
4 years, 1 month ago (2016-11-17 03:59:41 UTC) #28
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-17 04:15:23 UTC) #30
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 04:20:04 UTC) #32
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f1b03de69bfc005873519372c2f0afbc58093d77
Cr-Commit-Position: refs/heads/master@{#432737}

Powered by Google App Engine
This is Rietveld 408576698