chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/StaticTabSceneLayer.java - Issue 2499733002: Remove cached dp viewports in LayoutManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/StaticTabSceneLayer.java

Issue 2499733002: Remove cached dp viewports in LayoutManager (Closed)

Patch Set: use Float.compare Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayout.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/TabListSceneLayer.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/StaticTabSceneLayer.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/StaticTabSceneLayer.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/StaticTabSceneLayer.java

index 80bb8c19fcc064149c6583d0eff68ee532d9e750..20f5212995ae7e1264198811990555aee3c03a21 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/StaticTabSceneLayer.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/StaticTabSceneLayer.java

@@ -4,7 +4,7 @@

package org.chromium.chrome.browser.compositor.scene_layer;

-import android.graphics.Rect;

+import android.graphics.RectF;

import org.chromium.base.annotations.JNINamespace;

import org.chromium.chrome.browser.compositor.LayerTitleCache;

@@ -37,7 +37,7 @@ public class StaticTabSceneLayer extends SceneLayer {

* @param fullscreenManager The FullscreenManager.

* @param layoutTab The LayoutTab.

- public void update(float dpToPx, Rect contentViewport, LayerTitleCache layerTitleCache,

+ public void update(float dpToPx, RectF contentViewport, LayerTitleCache layerTitleCache,

TabContentManager tabContentManager, ChromeFullscreenManager fullscreenManager,

LayoutTab layoutTab) {

if (layoutTab == null) {