chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ToolbarSwipeLayout.java - Issue 2499733002: Remove cached dp viewports in LayoutManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ToolbarSwipeLayout.java

Issue 2499733002: Remove cached dp viewports in LayoutManager (Closed)

Patch Set: use Float.compare Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/StaticLayout.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/components/LayoutTab.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ToolbarSwipeLayout.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ToolbarSwipeLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ToolbarSwipeLayout.java

index 2c7ea787f0eb8e28c931eb0732c6dd3fe0f64de2..d1636d16f96786640573ab2b6f3029cc1ed73b77 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ToolbarSwipeLayout.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ToolbarSwipeLayout.java

@@ -6,7 +6,7 @@ package org.chromium.chrome.browser.compositor.layouts;

import android.content.Context;

import android.content.res.Resources;

-import android.graphics.Rect;

+import android.graphics.RectF;

import android.view.animation.DecelerateInterpolator;

import android.view.animation.Interpolator;

@@ -349,7 +349,7 @@ public class ToolbarSwipeLayout extends Layout implements Animatable<ToolbarSwip

}

@Override

- protected void updateSceneLayer(Rect viewport, Rect contentViewport,

+ protected void updateSceneLayer(RectF viewport, RectF contentViewport,

LayerTitleCache layerTitleCache, TabContentManager tabContentManager,

ResourceManager resourceManager, ChromeFullscreenManager fullscreenManager) {

super.updateSceneLayer(viewport, contentViewport, layerTitleCache, tabContentManager,