Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2499723002: Revert of Set analytic AA as default. (Closed)

Created:
4 years, 1 month ago by liyuqian
Modified:
4 years, 1 month ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Set analytic AA as default. (patchset #8 id:140001 of https://codereview.chromium.org/2471133002/ ) Reason for revert: SkASSERT triggered in some perf tests. Roll back. Original issue's description: > Set analytic AA as default. > > We'll use https://codereview.chromium.org/2471123002/ to keep Chrome from using > analytic AA until we fix all the Chrome tests. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2471133002 > > Committed: https://skia.googlesource.com/skia/+/dca4f6530013cf43a2557ccb07f5cb4fd916b8e8 TBR=fmalita@chromium.org,msarett@google.com,mtklein@google.com,reed@google.com,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/06dd5c77a6ca6c484c683f1006a7bb6742f8917e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -94 lines) Patch
M infra/bots/recipes/swarm_test.py View 1 chunk +0 lines, -3 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-Clang-AndroidOne-CPU-MT6582-arm-Release-GN_Android.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Release-GN_Android.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-Clang-GalaxyS7-GPU-Adreno530-arm64-Debug-GN_Android.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-Clang-NVIDIA_Shield-GPU-TegraX1-arm64-Debug-GN_Android.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-Clang-Nexus10-GPU-MaliT604-arm-Release-GN_Android.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-Clang-Nexus6-GPU-Adreno420-arm-Debug-GN_Android.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-Clang-Nexus7-GPU-Tegra3-arm-Debug-GN_Android.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-Clang-Nexus9-CPU-Denver-arm64-Debug-GN_Android.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Android-Clang-PixelC-GPU-TegraX1-arm64-Debug-GN_Android.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Mac-Clang-MacMini4.1-GPU-GeForce320M-x86_64-Debug.json View 1 chunk +0 lines, -4 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Debug.json View 1 chunk +0 lines, -4 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86-Debug.json View 1 chunk +0 lines, -4 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug.json View 1 chunk +0 lines, -4 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN.json View 1 chunk +0 lines, -4 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN.json View 1 chunk +0 lines, -4 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared.json View 1 chunk +0 lines, -4 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-TSAN.json View 1 chunk +0 lines, -4 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json View 3 chunks +0 lines, -12 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Release-Trybot.json View 1 chunk +0 lines, -4 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Debug.json View 1 chunk +0 lines, -4 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/big_issue_number.json View 1 chunk +0 lines, -4 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/failed_dm.json View 1 chunk +0 lines, -4 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/failed_get_hashes.json View 1 chunk +1 line, -1 line 0 comments Download
M infra/bots/recipes/swarm_test.expected/missing_SKP_VERSION_device.json View 1 chunk +0 lines, -4 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/nobuildbot.json View 1 chunk +0 lines, -4 lines 0 comments Download
M infra/bots/recipes/swarm_test.expected/recipe_with_gerrit_patch.json View 1 chunk +0 lines, -4 lines 0 comments Download
M src/core/SkAntiRun.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkScan.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/core/SkScan_AAAPath.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkXfermode.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M tests/ImageFilterTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
liyuqian
Created Revert of Set analytic AA as default.
4 years, 1 month ago (2016-11-11 21:30:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2499723002/1
4 years, 1 month ago (2016-11-11 21:30:40 UTC) #3
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 21:30:51 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/06dd5c77a6ca6c484c683f1006a7bb6742f8917e

Powered by Google App Engine
This is Rietveld 408576698