Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2499703002: gpu: Fix Mac fullscreen video (Closed)

Created:
4 years, 1 month ago by Fady Samuel
Modified:
4 years, 1 month ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Fix Mac fullscreen video https://codereview.chromium.org/2492583002/ introduced a bug where one of the SwapBufeersCompleteParams were dropped before sending an IPC to the gpu host. This CL plumbs the fullscreen_low_power_ca_context_id parameter and deletes a stale comment. BUG=664489 TBR=piman@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/8e56e9c3126ffa852351d14c2bd7d74e703e5827 Cr-Commit-Position: refs/heads/master@{#431652}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M gpu/ipc/service/gpu_command_buffer_stub.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/ipc/service/pass_through_image_transport_surface.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Fady Samuel
PTAL Antoine! I'm TBR'ing since this is trivial and fixes a bad bug.
4 years, 1 month ago (2016-11-11 20:45:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2499703002/1
4 years, 1 month ago (2016-11-11 20:47:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 21:36:18 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8e56e9c3126ffa852351d14c2bd7d74e703e5827 Cr-Commit-Position: refs/heads/master@{#431652}
4 years, 1 month ago (2016-11-11 21:45:06 UTC) #10
piman
4 years, 1 month ago (2016-11-11 22:56:24 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698