Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 2499693002: Fixes for URI and Object completions with the new driver. (Closed)

Created:
4 years, 1 month ago by scheglov
Modified:
4 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixes for URI and Object completions with the new driver. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/978ab8ed3dc6b102da872d8b2fade5a807183c58

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -10 lines) Patch
M pkg/analysis_server/lib/src/provisional/completion/dart/completion_dart.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart View 2 chunks +10 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/uri_contributor.dart View 3 chunks +3 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 4 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 1 month ago (2016-11-11 20:44:34 UTC) #1
Brian Wilkerson
lgtm
4 years, 1 month ago (2016-11-11 21:52:49 UTC) #2
scheglov
4 years, 1 month ago (2016-11-11 21:54:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
978ab8ed3dc6b102da872d8b2fade5a807183c58 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698