Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 249963002: FCMify layout tests with scrollbar rendering diffs (Closed)

Created:
6 years, 8 months ago by enne (OOO)
Modified:
6 years, 8 months ago
CC:
blink-reviews, mstensho+blink_opera.com
Visibility:
Public.

Description

FCMify layout tests with scrollbar rendering diffs Unfortunately in FCM, some scrollbars render imperceptibly different when run through Mesa due to texture filtering issues. To help make turning FCM on less painful, convert these tests to be FCM early and rebaseline them. BUG=361729 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172554

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rebase #

Patch Set 3 : Remove dupe #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -19 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 1 chunk +32 lines, -0 lines 0 comments Download
M LayoutTests/css2.1/20110323/block-non-replaced-height-002.htm View 1 chunk +6 lines, -1 line 0 comments Download
M LayoutTests/css2.1/20110323/block-non-replaced-height-004.htm View 2 chunks +6 lines, -1 line 0 comments Download
M LayoutTests/css2.1/20110323/block-non-replaced-height-006.htm View 2 chunks +6 lines, -1 line 0 comments Download
M LayoutTests/css2.1/20110323/block-non-replaced-height-008.htm View 2 chunks +6 lines, -1 line 0 comments Download
M LayoutTests/css2.1/20110323/block-non-replaced-height-010.htm View 2 chunks +6 lines, -1 line 0 comments Download
M LayoutTests/css2.1/20110323/block-non-replaced-height-012.htm View 1 chunk +6 lines, -1 line 0 comments Download
M LayoutTests/css2.1/20110323/block-non-replaced-height-014.htm View 1 chunk +6 lines, -1 line 0 comments Download
M LayoutTests/css2.1/20110323/block-non-replaced-height-016.htm View 2 chunks +6 lines, -1 line 0 comments Download
M LayoutTests/css2.1/t0803-c5502-mrgn-r-02-c.html View 1 chunk +6 lines, -1 line 0 comments Download
M LayoutTests/css2.1/t0803-c5505-mrgn-02-c.html View 1 chunk +6 lines, -1 line 0 comments Download
M LayoutTests/fast/block/float/021.html View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/fast/block/margin-collapse/104.html View 2 chunks +6 lines, -2 lines 0 comments Download
M LayoutTests/fast/block/positioning/relative-overflow-block.html View 1 chunk +6 lines, -1 line 0 comments Download
M LayoutTests/fast/block/positioning/relative-overflow-replaced.html View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/fast/block/positioning/relative-overflow-replaced-float.html View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/fast/body-propagation/overflow/001.html View 2 chunks +6 lines, -1 line 0 comments Download
M LayoutTests/fast/body-propagation/overflow/001-xhtml.xhtml View 2 chunks +6 lines, -1 line 0 comments Download
M LayoutTests/fast/body-propagation/overflow/005.html View 2 chunks +4 lines, -1 line 0 comments Download
M LayoutTests/fast/body-propagation/overflow/005-declarative.xhtml View 2 chunks +6 lines, -1 line 0 comments Download
M LayoutTests/fast/body-propagation/overflow/005-xhtml.xhtml View 2 chunks +4 lines, -1 line 0 comments Download
M LayoutTests/fast/multicol/pagination-h-horizontal-bt.html View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/fast/multicol/pagination-h-horizontal-tb.html View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/fast/multicol/pagination-h-vertical-lr.html View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/fast/multicol/pagination-h-vertical-rl.html View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/fast/multicol/scrolling-overflow.html View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/overflow/006.html View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/fast/overflow/paged-x-on-root.html View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/fast/overflow/paged-x-with-column-gap.html View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
enne (OOO)
6 years, 8 months ago (2014-04-23 20:57:08 UTC) #1
mstensho (USE GERRIT)
https://codereview.chromium.org/249963002/diff/1/LayoutTests/fast/overflow/paged-x-on-root.html File LayoutTests/fast/overflow/paged-x-on-root.html (right): https://codereview.chromium.org/249963002/diff/1/LayoutTests/fast/overflow/paged-x-on-root.html#newcode6 LayoutTests/fast/overflow/paged-x-on-root.html:6: if (window.internals) { Twice? :)
6 years, 8 months ago (2014-04-23 21:17:27 UTC) #2
enne (OOO)
https://codereview.chromium.org/249963002/diff/1/LayoutTests/fast/overflow/paged-x-on-root.html File LayoutTests/fast/overflow/paged-x-on-root.html (right): https://codereview.chromium.org/249963002/diff/1/LayoutTests/fast/overflow/paged-x-on-root.html#newcode6 LayoutTests/fast/overflow/paged-x-on-root.html:6: if (window.internals) { On 2014/04/23 21:17:27, Morten Stenshorne wrote: ...
6 years, 8 months ago (2014-04-23 21:24:34 UTC) #3
enne (OOO)
https://codereview.chromium.org/249963002/diff/1/LayoutTests/fast/overflow/paged-x-on-root.html File LayoutTests/fast/overflow/paged-x-on-root.html (right): https://codereview.chromium.org/249963002/diff/1/LayoutTests/fast/overflow/paged-x-on-root.html#newcode6 LayoutTests/fast/overflow/paged-x-on-root.html:6: if (window.internals) { On 2014/04/23 21:24:35, enne wrote: > ...
6 years, 8 months ago (2014-04-24 18:36:06 UTC) #4
ojan
lgtm
6 years, 8 months ago (2014-04-24 18:45:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/249963002/60001
6 years, 8 months ago (2014-04-24 18:46:01 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 23:25:58 UTC) #7
Message was sent while issue was closed. 
Change committed as 172554

Powered by Google App Engine
This is Rietveld 408576698