Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Side by Side Diff: content/renderer/render_widget.cc

Issue 2499623002: Make PostTask and Send failures in input routing fatal. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_widget.h" 5 #include "content/renderer/render_widget.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/auto_reset.h" 10 #include "base/auto_reset.h"
(...skipping 531 matching lines...) Expand 10 before | Expand all | Expand 10 after
542 return false; 542 return false;
543 } 543 }
544 544
545 // If given a messsage without a routing ID, then assign our routing ID. 545 // If given a messsage without a routing ID, then assign our routing ID.
546 if (message->routing_id() == MSG_ROUTING_NONE) 546 if (message->routing_id() == MSG_ROUTING_NONE)
547 message->set_routing_id(routing_id_); 547 message->set_routing_id(routing_id_);
548 548
549 return RenderThread::Get()->Send(message); 549 return RenderThread::Get()->Send(message);
550 } 550 }
551 551
552 void RenderWidget::SendOrCrash(IPC::Message* message) {
553 bool result = Send(message);
554 CHECK(closing_ || result) << "Failed to send message";
555 }
556
552 void RenderWidget::SetWindowRectSynchronously( 557 void RenderWidget::SetWindowRectSynchronously(
553 const gfx::Rect& new_window_rect) { 558 const gfx::Rect& new_window_rect) {
554 ResizeParams params; 559 ResizeParams params;
555 params.screen_info = screen_info_; 560 params.screen_info = screen_info_;
556 params.new_size = new_window_rect.size(); 561 params.new_size = new_window_rect.size();
557 params.physical_backing_size = 562 params.physical_backing_size =
558 gfx::ScaleToCeiledSize(new_window_rect.size(), device_scale_factor_); 563 gfx::ScaleToCeiledSize(new_window_rect.size(), device_scale_factor_);
559 params.visible_viewport_size = new_window_rect.size(); 564 params.visible_viewport_size = new_window_rect.size();
560 params.is_fullscreen_granted = is_fullscreen_granted_; 565 params.is_fullscreen_granted = is_fullscreen_granted_;
561 params.display_mode = display_mode_; 566 params.display_mode = display_mode_;
(...skipping 313 matching lines...) Expand 10 before | Expand all | Expand 10 after
875 void RenderWidget::ClearEditCommands() { 880 void RenderWidget::ClearEditCommands() {
876 edit_commands_.clear(); 881 edit_commands_.clear();
877 } 882 }
878 883
879 void RenderWidget::OnDidOverscroll(const ui::DidOverscrollParams& params) { 884 void RenderWidget::OnDidOverscroll(const ui::DidOverscrollParams& params) {
880 Send(new InputHostMsg_DidOverscroll(routing_id_, params)); 885 Send(new InputHostMsg_DidOverscroll(routing_id_, params));
881 } 886 }
882 887
883 void RenderWidget::OnInputEventAck( 888 void RenderWidget::OnInputEventAck(
884 std::unique_ptr<InputEventAck> input_event_ack) { 889 std::unique_ptr<InputEventAck> input_event_ack) {
885 Send(new InputHostMsg_HandleInputEvent_ACK(routing_id_, *input_event_ack)); 890 SendOrCrash(
891 new InputHostMsg_HandleInputEvent_ACK(routing_id_, *input_event_ack));
886 } 892 }
887 893
888 void RenderWidget::NotifyInputEventHandled( 894 void RenderWidget::NotifyInputEventHandled(
889 blink::WebInputEvent::Type handled_type, 895 blink::WebInputEvent::Type handled_type,
890 InputEventAckState ack_result) { 896 InputEventAckState ack_result) {
891 RenderThreadImpl* render_thread = RenderThreadImpl::current(); 897 RenderThreadImpl* render_thread = RenderThreadImpl::current();
892 InputHandlerManager* input_handler_manager = 898 InputHandlerManager* input_handler_manager =
893 render_thread ? render_thread->input_handler_manager() : NULL; 899 render_thread ? render_thread->input_handler_manager() : NULL;
894 if (input_handler_manager) { 900 if (input_handler_manager) {
895 input_handler_manager->NotifyInputEventHandledOnMainThread( 901 input_handler_manager->NotifyInputEventHandledOnMainThread(
(...skipping 1214 matching lines...) Expand 10 before | Expand all | Expand 10 after
2110 blink::WebInputMethodController* RenderWidget::GetInputMethodController() 2116 blink::WebInputMethodController* RenderWidget::GetInputMethodController()
2111 const { 2117 const {
2112 // TODO(ekaramad): Remove this CHECK when GetWebWidget() is 2118 // TODO(ekaramad): Remove this CHECK when GetWebWidget() is
2113 // always a WebFrameWidget. 2119 // always a WebFrameWidget.
2114 CHECK(GetWebWidget()->isWebFrameWidget()); 2120 CHECK(GetWebWidget()->isWebFrameWidget());
2115 return static_cast<blink::WebFrameWidget*>(GetWebWidget()) 2121 return static_cast<blink::WebFrameWidget*>(GetWebWidget())
2116 ->getActiveWebInputMethodController(); 2122 ->getActiveWebInputMethodController();
2117 } 2123 }
2118 2124
2119 } // namespace content 2125 } // namespace content
OLDNEW
« content/renderer/render_widget.h ('K') | « content/renderer/render_widget.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698