Issue 24996003: Revert "Add methods to enable configuration of ResourceConstraints based on limits derived at runti…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24996003: Revert "Add methods to enable configuration of ResourceConstraints based on limits derived at runti… (Closed)

Created:
7 years, 2 months ago by Michael Achenbach

Modified:
7 years, 2 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Revert "Add methods to enable configuration of ResourceConstraints based on limits derived at runtime." and "Fix Windows build of defaults.cc." This reverts commit r16964 and r16968 due to performance regressions in octane. TBR=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16979

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 7 years, 2 months ago

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -199 lines)
M	include/v8.h	View	1 chunk	+0 lines, -3 lines	0 comments
D	include/v8-defaults.h	View	1 chunk	+0 lines, -54 lines	0 comments
M	include/v8-testing.h	View	1 chunk	+4 lines, -0 lines	0 comments
M	src/d8.cc	View	3 chunks	+0 lines, -3 lines	0 comments
D	src/defaults.cc	View	1 chunk	+0 lines, -71 lines	0 comments
M	src/globals.h	View	1 chunk	+0 lines, -2 lines	0 comments
M	src/heap.cc	View	2 chunks	+20 lines, -8 lines	0 comments
M	src/platform.h	View	1 chunk	+0 lines, -3 lines	0 comments
M	src/platform-posix.cc	View	1 chunk	+0 lines, -42 lines	0 comments
M	src/platform-win32.cc	View	1 chunk	+0 lines, -12 lines	0 comments
M	tools/gyp/v8.gyp	View	1 chunk	+0 lines, -1 line	0 comments

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Achenbach

Committed patchset #2 manually as r16979 (presubmit successful).

7 years, 2 months ago (2013-09-27 09:45:31 UTC) #2

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages