Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2499593003: [ios] Removed back-forward navigation API from CRWWebController. (Closed)

Created:
4 years, 1 month ago by Eugene But (OOO till 7-30)
Modified:
4 years, 1 month ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Removed back-forward navigation API from CRWWebController. NavigationManager API should be used for navigation instead. BUG=661316 Committed: https://crrev.com/f00c143bc322f36f5ff919620fd57b2e021a3262 Cr-Commit-Position: refs/heads/master@{#432369}

Patch Set 1 #

Patch Set 2 : Self review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -25 lines) Patch
M ios/web/web_state/ui/crw_web_controller.h View 2 chunks +0 lines, -7 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 1 3 chunks +2 lines, -18 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Eugene But (OOO till 7-30)
4 years, 1 month ago (2016-11-15 00:11:00 UTC) #6
kkhorimoto
lgtm. yay, I love this CL! :)
4 years, 1 month ago (2016-11-16 02:31:00 UTC) #7
Eugene But (OOO till 7-30)
Glad to hear that :)
4 years, 1 month ago (2016-11-16 02:32:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2499593003/20001
4 years, 1 month ago (2016-11-16 02:33:08 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-16 02:55:36 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f00c143bc322f36f5ff919620fd57b2e021a3262 Cr-Commit-Position: refs/heads/master@{#432369}
4 years, 1 month ago (2016-11-16 02:57:25 UTC) #13
Eugene But (OOO till 7-30)
4 years, 1 month ago (2016-11-16 03:42:12 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2509493003/ by eugenebut@chromium.org.

The reason for reverting is: Breaks upstream unit test..

Powered by Google App Engine
This is Rietveld 408576698