Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2499593002: Make private symbols non-enumerable (Closed)

Created:
4 years, 1 month ago by Toon Verwaest
Modified:
4 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make private symbols non-enumerable Methods in the runtime that enumerate over properties should never deal with private symbols. Most commonly such methods only loop over enumerable properties. This fix avoids accidentally handling private symbols in methods that only deal with enumerable properties. Methods that need to look at non-enumerable properties as well still have to manually filter private symbols (e.g., the KeyAccumulator). BUG=chromium:664411 Committed: https://crrev.com/135b9f9360342089de151990a7bf61c31caa6f1f Cr-Commit-Position: refs/heads/master@{#40932}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M src/lookup.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M src/property.h View 3 chunks +3 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/private.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 1 month ago (2016-11-11 11:07:02 UTC) #2
Jakob Kummerow
lgtm
4 years, 1 month ago (2016-11-11 14:31:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2499593002/1
4 years, 1 month ago (2016-11-11 14:37:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 15:05:01 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:31:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/135b9f9360342089de151990a7bf61c31caa6f1f
Cr-Commit-Position: refs/heads/master@{#40932}

Powered by Google App Engine
This is Rietveld 408576698