Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2499563003: [Devtools] Fixed bug with ViewPortDataGrid not always revealing nodes (Closed)

Created:
4 years, 1 month ago by allada
Modified:
4 years, 1 month ago
Reviewers:
dgozman, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Fixed bug with ViewPortDataGrid not always revealing nodes This patch fixes a bug where if an expand() is called on a node the ViewPortDataGrid would not set it to revealed when inserting it into the dom. R=dgozman,lushnikov BUG=664689 Committed: https://crrev.com/c8b5e8226b6a5de2d27ca6dd0c73a1ea3f298c8d Cr-Commit-Position: refs/heads/master@{#431762}

Patch Set 1 : [Devtools] Fixed bug with ViewPortDataGrid not always revealing nodes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui_lazy/ViewportDataGrid.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
allada
PTL
4 years, 1 month ago (2016-11-12 00:55:22 UTC) #1
lushnikov
lgtm
4 years, 1 month ago (2016-11-12 01:29:55 UTC) #3
lushnikov
lgtm lgtm
4 years, 1 month ago (2016-11-12 01:29:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2499563003/20001
4 years, 1 month ago (2016-11-12 02:10:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 1 month ago (2016-11-12 03:44:07 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-12 03:47:33 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c8b5e8226b6a5de2d27ca6dd0c73a1ea3f298c8d
Cr-Commit-Position: refs/heads/master@{#431762}

Powered by Google App Engine
This is Rietveld 408576698