content/shell/browser/shell_devtools_delegate.h - Issue 24995003: DevTools: Extract target discovery and manipulation from DevToolsHttpHandlerImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/shell_devtools_delegate.h

Issue 24995003: DevTools: Extract target discovery and manipulation from DevToolsHttpHandlerImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added Android implementations Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/browser/devtools_target_descriptor.h ('K') | « content/public/browser/devtools_target_descriptor.h ('k') | content/shell/browser/shell_devtools_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/shell_devtools_delegate.h

diff --git a/content/shell/browser/shell_devtools_delegate.h b/content/shell/browser/shell_devtools_delegate.h

index ad694c515e0219063c12780e477a2d3f528bf2d6..9fa62dd1e102f082225506dac33d0741ecc59033 100644

--- a/content/shell/browser/shell_devtools_delegate.h

+++ b/content/shell/browser/shell_devtools_delegate.h

@@ -26,10 +26,14 @@ class ShellDevToolsDelegate : public DevToolsHttpHandlerDelegate {

virtual std::string GetDiscoveryPageHTML() OVERRIDE;

virtual bool BundlesFrontendResources() OVERRIDE;

virtual base::FilePath GetDebugFrontendDir() OVERRIDE;

- virtual std::string GetPageThumbnailData(const GURL& url) OVERRIDE;

- virtual RenderViewHost* CreateNewTarget() OVERRIDE;

- virtual TargetType GetTargetType(RenderViewHost*) OVERRIDE;

- virtual std::string GetViewDescription(content::RenderViewHost*) OVERRIDE;

+ virtual bool SupportsPageThumbnails() OVERRIDE;

+ virtual std::string GetPageThumbnailData(const std::string& id) OVERRIDE;

+ virtual Target* CreateNewTarget() OVERRIDE;

+ virtual bool ActivateTarget(const std::string& id) OVERRIDE;

+ virtual bool CloseTarget(const std::string& id) OVERRIDE;

+ virtual scoped_refptr<content::DevToolsAgentHost> GetAgentHost(

+ const std::string& id) OVERRIDE;

+ virtual void RequestTargets(TargetCallback callback) OVERRIDE;

virtual scoped_ptr<net::StreamListenSocket> CreateSocketForTethering(

net::StreamListenSocket::Delegate* delegate,

std::string* name) OVERRIDE;