Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: content/browser/devtools/devtools_http_handler_unittest.cc

Issue 24995003: DevTools: Extract target discovery and manipulation from DevToolsHttpHandlerImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added Android implementations Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/devtools_http_handler_unittest.cc
diff --git a/content/browser/devtools/devtools_http_handler_unittest.cc b/content/browser/devtools/devtools_http_handler_unittest.cc
index a57c4ccd4cdd9ccab40973a5e06efb9cd90cc526..c3728a76699df36e0a5d7d4a4b8e73efaf4ce1ce 100644
--- a/content/browser/devtools/devtools_http_handler_unittest.cc
+++ b/content/browser/devtools/devtools_http_handler_unittest.cc
@@ -5,6 +5,7 @@
#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
#include "content/browser/browser_thread_impl.h"
+#include "content/public/browser/devtools_agent_host.h"
#include "content/public/browser/devtools_http_handler.h"
#include "content/public/browser/devtools_http_handler_delegate.h"
#include "net/socket/stream_listen_socket.h"
@@ -61,16 +62,19 @@ class DummyDelegate : public DevToolsHttpHandlerDelegate {
virtual base::FilePath GetDebugFrontendDir() OVERRIDE {
return base::FilePath();
}
- virtual std::string GetPageThumbnailData(const GURL& url) OVERRIDE {
+ virtual bool SupportsPageThumbnails() OVERRIDE { return false; }
+ virtual std::string GetPageThumbnailData(const std::string& id) OVERRIDE {
return std::string();
}
- virtual RenderViewHost* CreateNewTarget() OVERRIDE { return NULL; }
- virtual TargetType GetTargetType(RenderViewHost*) OVERRIDE {
- return kTargetTypeTab;
- }
- virtual std::string GetViewDescription(content::RenderViewHost*) OVERRIDE {
- return std::string();
+ virtual Target* CreateNewTarget() OVERRIDE { return NULL; }
+ virtual bool ActivateTarget(const std::string& id) OVERRIDE { return false; }
+ virtual bool CloseTarget(const std::string& id) OVERRIDE { return false; }
+
+ virtual scoped_refptr<content::DevToolsAgentHost> GetAgentHost(
+ const std::string& id) OVERRIDE {
+ return NULL;
}
+ virtual void RequestTargets(TargetCallback callback) OVERRIDE {}
virtual scoped_ptr<net::StreamListenSocket> CreateSocketForTethering(
net::StreamListenSocket::Delegate* delegate,
std::string* name) OVERRIDE {

Powered by Google App Engine
This is Rietveld 408576698