Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1312)

Unified Diff: content/public/browser/devtools_http_handler.h

Issue 24995003: DevTools: Extract target discovery and manipulation from DevToolsHttpHandlerImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed json/new handler Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/content_browser.gypi ('k') | content/public/browser/devtools_http_handler_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/devtools_http_handler.h
diff --git a/content/public/browser/devtools_http_handler.h b/content/public/browser/devtools_http_handler.h
index 95cf4077ebaaf1a963e586826825907d70e8ce7a..4af55059da954deb9ccae07087624164aab39a56 100644
--- a/content/public/browser/devtools_http_handler.h
+++ b/content/public/browser/devtools_http_handler.h
@@ -18,7 +18,6 @@ class URLRequestContextGetter;
namespace content {
-class DevToolsAgentHost;
class DevToolsHttpHandlerDelegate;
// This class is used for managing DevTools remote debugging server.
@@ -26,19 +25,6 @@ class DevToolsHttpHandlerDelegate;
// this browser.
class DevToolsHttpHandler {
public:
- // Interface responsible for mapping DevToolsAgentHost instances to/from
- // string identifiers.
- class DevToolsAgentHostBinding {
- public:
- virtual ~DevToolsAgentHostBinding() {}
-
- // Returns the mapping of DevToolsAgentHost to identifier.
- virtual std::string GetIdentifier(DevToolsAgentHost* agent_host) = 0;
-
- // Returns the mapping of identifier to DevToolsAgentHost.
- virtual DevToolsAgentHost* ForIdentifier(const std::string& identifier) = 0;
- };
-
// Returns true if the given protocol version is supported.
CONTENT_EXPORT static bool IsSupportedProtocolVersion(
const std::string& version);
@@ -57,13 +43,8 @@ class DevToolsHttpHandler {
// Automatically destroys the handler instance.
virtual void Stop() = 0;
- // Set the DevToolsAgentHostBinding instance. If no instance is provided the
- // default implementation will be used.
- virtual void SetDevToolsAgentHostBinding(
- DevToolsAgentHostBinding* binding) = 0;
-
- // Returns the URL for the address to debug |render_view_host|.
- virtual GURL GetFrontendURL(DevToolsAgentHost* agent_host) = 0;
+ // Returns the URL for the address to debug |agent_host|.
+ virtual GURL GetFrontendURL() = 0;
protected:
virtual ~DevToolsHttpHandler() {}
« no previous file with comments | « content/content_browser.gypi ('k') | content/public/browser/devtools_http_handler_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698