Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: content/browser/devtools/devtools_http_handler_unittest.cc

Issue 24995003: DevTools: Extract target discovery and manipulation from DevToolsHttpHandlerImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed json/new handler Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/devtools/devtools_http_handler_impl.cc ('k') | content/content_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/devtools_http_handler_unittest.cc
diff --git a/content/browser/devtools/devtools_http_handler_unittest.cc b/content/browser/devtools/devtools_http_handler_unittest.cc
index a57c4ccd4cdd9ccab40973a5e06efb9cd90cc526..cc751f0397907900a751968942b83d5d60295128 100644
--- a/content/browser/devtools/devtools_http_handler_unittest.cc
+++ b/content/browser/devtools/devtools_http_handler_unittest.cc
@@ -7,6 +7,7 @@
#include "content/browser/browser_thread_impl.h"
#include "content/public/browser/devtools_http_handler.h"
#include "content/public/browser/devtools_http_handler_delegate.h"
+#include "content/public/browser/devtools_target.h"
#include "net/socket/stream_listen_socket.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -64,12 +65,11 @@ class DummyDelegate : public DevToolsHttpHandlerDelegate {
virtual std::string GetPageThumbnailData(const GURL& url) OVERRIDE {
return std::string();
}
- virtual RenderViewHost* CreateNewTarget() OVERRIDE { return NULL; }
- virtual TargetType GetTargetType(RenderViewHost*) OVERRIDE {
- return kTargetTypeTab;
+ virtual scoped_ptr<DevToolsTarget> CreateNewTarget() OVERRIDE {
+ return scoped_ptr<DevToolsTarget>();
}
- virtual std::string GetViewDescription(content::RenderViewHost*) OVERRIDE {
- return std::string();
+ virtual void EnumerateTargets(TargetCallback callback) OVERRIDE {
+ callback.Run(TargetList());
}
virtual scoped_ptr<net::StreamListenSocket> CreateSocketForTethering(
net::StreamListenSocket::Delegate* delegate,
« no previous file with comments | « content/browser/devtools/devtools_http_handler_impl.cc ('k') | content/content_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698