chrome/test/data/devtools/target_list/background.js - Issue 24995003: DevTools: Extract target discovery and manipulation from DevToolsHttpHandlerImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/devtools/target_list/background.js

Issue 24995003: DevTools: Extract target discovery and manipulation from DevToolsHttpHandlerImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed json/new handler Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/browser_list_tabcontents_provider.cc ('k') | content/browser/devtools/devtools_http_handler_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/devtools/target_list/background.js

diff --git a/chrome/test/data/devtools/target_list/background.js b/chrome/test/data/devtools/target_list/background.js

index 19514e32b54f3f65878c6bd362ae0b6c57b414cd..607f1e55d7f1db3693eb46271583a3d5fff710e3 100644

--- a/chrome/test/data/devtools/target_list/background.js

+++ b/chrome/test/data/devtools/target_list/background.js

@@ -34,7 +34,9 @@ function checkTarget(targets, url, type, opt_title, opt_faviconUrl) {

// a freshly created tab. Ignore the check then.

if (target.faviconUrl)

chrome.test.assertEq(opt_faviconUrl, target.faviconUrl);

- chrome.test.assertEq('/thumb/' + target.id, target.thumbnailUrl);

+ // Sometimes thumbnailUrl is not available for a freshly loaded tab.

+ if (target.thumbnailUrl)

+ chrome.test.assertEq('/thumb/' + target.id, target.thumbnailUrl);

chrome.test.assertEq(opt_title || target.url, target.title);

chrome.test.assertEq(type, target.type);

chrome.test.assertEq('ws://' + wsAddress, target.webSocketDebuggerUrl);