DevTools: Extract target discovery and manipulation from DevToolsHttpHandlerImpl

content/public/browser/devtools_target.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_PUBLIC_BROWSER_DEVTOOLS_TARGET_H_
+#define CONTENT_PUBLIC_BROWSER_DEVTOOLS_TARGET_H_
+
+#include <string>
+
+#include "base/basictypes.h"
+#include "base/memory/ref_counted.h"
+#include "base/time/time.h"
+#include "content/common/content_export.h"
+#include "content/public/browser/devtools_agent_host.h"

[jam, 2013/10/01 17:20:51]

nit: forward declare instead

[Vladislav Kaznacheev, 2013/10/02 10:28:29]

Done.

+#include "url/gurl.h"
+
+namespace content {
+
+class CONTENT_EXPORT DevToolsTarget : public base::RefCounted<DevToolsTarget> {

[jam, 2013/10/01 17:20:51]

1) why is this ref counted?
2) i dont think it needs to be exported since it's just an interface
3) add a comment about what this interface is used for

[Vladislav Kaznacheev, 2013/10/02 10:28:29]

ref counted no longer, CONTENT_EXPORT removed, comment added

On 2013/10/01 17:20:51, jam wrote:
Done.

+ public:
+  // Returns the unique target id.
+  virtual std::string GetId() const = 0;
+
+  // Returns the target type.
+  virtual std::string GetType() const = 0;
+
+  // Returns the target title.
+  virtual std::string GetTitle() const = 0;
+
+  // Returns the target description.
+  virtual std::string GetDescription() const = 0;
+
+  // Returns the url associated with this target.
+  virtual GURL GetUrl() const = 0;
+
+  // Returns the favicon url for this target.
+  virtual GURL GetFaviconUrl() const = 0;
+
+  // Returns the time when the target was last active.
+  virtual base::TimeTicks GetLastActivityTime() const = 0;
+
+  // Returns true if the debugger is attached to the target.
+  virtual bool IsAttached() const = 0;
+
+  // Returns the agent host for this target.
+  virtual scoped_refptr<DevToolsAgentHost> GetAgentHost() const = 0;
+
+  // Activates the target. Returns false if the operation failed.
+  virtual bool Activate() const = 0;
+
+  // Closes the target. Returns false if the operation failed.
+  virtual bool Close() const = 0;
+
+ protected:
+  friend class base::RefCounted<DevToolsTarget>;
+
+  virtual ~DevToolsTarget() {}
+};
+
+}  // namespace content
+
+#endif  // CONTENT_PUBLIC_BROWSER_DEVTOOLS_TARGET_H_