Communicate ExtensionSettings policy to renderers

extensions/common/extension_messages.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // IPC messages for extensions.
 // Multiply-included message file, hence no include guard.
 
 #include <stdint.h>
 
 #include <string>
@@ skipping 281 matching lines @@
   extensions::Manifest::Location location;
 
   // The path the extension was loaded from. This is used in the renderer only
   // to generate the extension ID for extensions that are loaded unpacked.
   base::FilePath path;
 
   // The extension's active and withheld permissions.
   ExtensionMsg_PermissionSetStruct active_permissions;
   ExtensionMsg_PermissionSetStruct withheld_permissions;
   std::map<int, ExtensionMsg_PermissionSetStruct> tab_specific_permissions;
+  extensions::URLPatternSet runtime_blocked_hosts;
+  extensions::URLPatternSet runtime_allowed_hosts;

[asargent_no_longer_on_chrome, 2016/11/23 01:19:23]

Do we have any sort of limitation on the size of these lists? I'm worried about
the cost of copying data for this IPC as currently specified if they contain
hundreds/thousands or more of entries.

If we do want to handle more than a few 10's of entries for these lists, we
probably want to rethink the design of how we share/update this data to account
for this. (For instance, something like shared memory segments or passing a
handle to a file on disk). 

[nrpeter, 2017/01/02 19:57:45]

Updated to use SharedMemoryHandle, this should let us handle huge
URLPatternSets.

 
   // We keep this separate so that it can be used in logging.
   std::string id;
 
   // Send creation flags so extension is initialized identically.
   int creation_flags;
 };
 
 struct ExtensionHostMsg_AutomationQuerySelector_Error {
   enum Value { kNone, kNoMainFrame, kNoDocument, kNodeDestroyed };
@@ skipping 104 matching lines @@
 IPC_STRUCT_TRAITS_MEMBER(value)
 IPC_STRUCT_TRAITS_END()
 
 // Parameters structure for ExtensionMsg_UpdatePermissions.
 IPC_STRUCT_BEGIN(ExtensionMsg_UpdatePermissions_Params)
   IPC_STRUCT_MEMBER(std::string, extension_id)
   IPC_STRUCT_MEMBER(ExtensionMsg_PermissionSetStruct, active_permissions)
   IPC_STRUCT_MEMBER(ExtensionMsg_PermissionSetStruct, withheld_permissions)
 IPC_STRUCT_END()
 
+// Parameters structure for ExtensionMsg_UpdatePolicy.
+IPC_STRUCT_BEGIN(ExtensionMsg_UpdatePolicy_Params)
+  IPC_STRUCT_MEMBER(std::string, extension_id)
+  IPC_STRUCT_MEMBER(extensions::URLPatternSet, runtime_blocked_hosts)
+  IPC_STRUCT_MEMBER(extensions::URLPatternSet, runtime_allowed_hosts)
+IPC_STRUCT_END()
+
 // Messages sent from the browser to the renderer:
 
 // The browser sends this message in response to all extension api calls. The
 // response data (if any) is one of the base::Value subclasses, wrapped as the
 // first element in a ListValue.
 IPC_MESSAGE_ROUTED4(ExtensionMsg_Response,
                     int /* request_id */,
                     bool /* success */,
                     base::ListValue /* response wrapper (see comment above) */,
                     std::string /* error */)
@@ skipping 78 matching lines @@
                     int /* id of browser window */)
 
 // Tell the render view what its tab ID is.
 IPC_MESSAGE_ROUTED1(ExtensionMsg_SetTabId,
                     int /* id of tab */)
 
 // Tell the renderer to update an extension's permission set.
 IPC_MESSAGE_CONTROL1(ExtensionMsg_UpdatePermissions,
                      ExtensionMsg_UpdatePermissions_Params)
 
+// Tell the renderer to update an extension's runtime_blocked_hosts set.
+IPC_MESSAGE_CONTROL1(ExtensionMsg_UpdatePolicy,

[asargent_no_longer_on_chrome, 2016/11/23 01:19:23]

"UpdatePolicy" is a little ambiguous of a name here, since there are a lot of
policies that apply to extensions and this message is about a fairly particular
one. 

Also, we could conceivably want to at some point allow users to manually adjust
the runtime allowed/blocked hosts lists themselves in non-enterprise managed
scenarios, so it would be better to use names that are agnostic of the source of
the allowed/blocked lists. 

How about something like "UpdateAllowedAndBlockedHosts"?

[nrpeter, 2017/01/02 19:57:45]

Done.

+                     ExtensionMsg_UpdatePolicy_Params)
+
 // Tell the render view about new tab-specific permissions for an extension.
 IPC_MESSAGE_CONTROL5(ExtensionMsg_UpdateTabSpecificPermissions,
                      GURL /* url */,
                      std::string /* extension_id */,
                      extensions::URLPatternSet /* hosts */,
                      bool /* update origin whitelist */,
                      int /* tab_id */)
 
 // Tell the render view to clear tab-specific permissions for some extensions.
 IPC_MESSAGE_CONTROL3(ExtensionMsg_ClearTabSpecificPermissions,
@@ skipping 360 matching lines @@
                      int64_t /* service_worker_version_id */,
                      std::string /* request_uuid */)
 
 // Asks the browser to decrement the pending activity count for
 // the worker with version id |service_worker_version_id|.
 // |request_uuid| must match the GUID of a previous request, otherwise the
 // browser process ignores the IPC.
 IPC_MESSAGE_CONTROL2(ExtensionHostMsg_DecrementServiceWorkerActivity,
                      int64_t /* service_worker_version_id */,
                      std::string /* request_uuid */)