Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2499473002: Bring in the latest dart_style to the SDK. (Closed)

Created:
4 years, 1 month ago by Bob Nystrom
Modified:
4 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, Bill Hesse
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Bring in the latest dart_style to the SDK. This pulls in the latest commit off GitHub to get the bots passing again since analyzer has a breaking change in the SDK that hasn't been released yet. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/4de1cb320bab432359fdeb38bba1897e31d6655f

Patch Set 1 #

Patch Set 2 : Use mirror. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
4 years, 1 month ago (2016-11-10 23:57:23 UTC) #2
Brian Wilkerson
lgtm
4 years, 1 month ago (2016-11-11 00:10:29 UTC) #3
Bob Nystrom
4 years, 1 month ago (2016-11-11 00:51:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4de1cb320bab432359fdeb38bba1897e31d6655f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698