Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: ash/common/system/chromeos/ime_menu/ime_menu_tray.cc

Issue 2499453002: Add ink drop ripple to overview mode button (Closed)
Patch Set: Addressed review comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/system/chromeos/ime_menu/ime_menu_tray.cc
diff --git a/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc b/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc
index f90ccbb6a85fee19fa1e59d276c4a45a2cf2c7cf..c4e72668cb49ee4b1488e0d313b5a77e69252e68 100644
--- a/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc
+++ b/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc
@@ -319,7 +319,7 @@ ImeMenuTray::ImeMenuTray(WmShelf* wm_shelf)
should_block_shelf_auto_hide_(false) {
SetupLabelForTray(label_);
tray_container()->AddChildView(label_);
- SetContentsBackground();
+ SetContentsBackground(true);
WmShell::Get()->system_tray_notifier()->AddIMEObserver(this);
}
@@ -392,13 +392,13 @@ void ImeMenuTray::ShowImeMenuBubble() {
}
bubble_.reset(new TrayBubbleWrapper(this, bubble_view));
- SetDrawBackgroundAsActive(true);
+ SetIsActive(true);
}
void ImeMenuTray::HideImeMenuBubble() {
bubble_.reset();
ime_list_view_ = nullptr;
- SetDrawBackgroundAsActive(false);
+ SetIsActive(false);
should_block_shelf_auto_hide_ = false;
shelf()->UpdateAutoHideState();
}

Powered by Google App Engine
This is Rietveld 408576698